[1/1] input: elan_i2c - add support for ELAN061A touchpad
diff mbox series

Message ID 18e75b87-a83f-7c96-9360-469b9c53741f@der-ingo.de
State New
Headers show
Series
  • [1/1] input: elan_i2c - add support for ELAN061A touchpad
Related show

Commit Message

Ingo Lafrenz Dec. 24, 2018, 9:28 a.m. UTC
Add ELAN061A to the ACPI table to support Elan touchpad found in Lenovo
V130-15IGM laptops

Signed-off-by: Ingo Lafrenz <ich+linux@der-ingo.de>

---
I have tested this successfully against the 4.19.11 kernel. Please note
that since kernel v4.18 the driver generates a looot of 'invalid report
id data (ff)' messages with this touchpad. So even the touchpad seems
fully functional for me there might be more to it than just adding the ID.
Please consider this when taking this patch, otherwise the logs will
be flooded with tons of messages.

Comments

Dmitry Torokhov Dec. 24, 2018, 5:37 p.m. UTC | #1
On Mon, Dec 24, 2018 at 10:28:45AM +0100, Ingo Lafrenz wrote:
> Add ELAN061A to the ACPI table to support Elan touchpad found in Lenovo
> V130-15IGM laptops
> 
> Signed-off-by: Ingo Lafrenz <ich+linux@der-ingo.de>
> 
> ---
> I have tested this successfully against the 4.19.11 kernel. Please note
> that since kernel v4.18 the driver generates a looot of 'invalid report
> id data (ff)' messages with this touchpad. So even the touchpad seems
> fully functional for me there might be more to it than just adding the ID.
> Please consider this when taking this patch, otherwise the logs will
> be flooded with tons of messages.

Are you saying that with this patch applied to 4.18 you do not see the
"ff" flood? After 4.18 I only see additions of ACPI IDs to the driver,
any chance you could bisect to see what causes invalid report messages?

> 
> diff --git a/drivers/input/mouse/elan_i2c_core.c
> b/drivers/input/mouse/elan_i2c_core.c
> index 2690a4b7ed53..7cacacfb90e3 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -1344,6 +1344,7 @@ static const struct acpi_device_id elan_acpi_id[] = {
>      { "ELAN060B", 0 },
>      { "ELAN060C", 0 },
>      { "ELAN0611", 0 },
> +    { "ELAN061A", 0 },
>      { "ELAN1000", 0 },
>      { }
>  };
> 

Thanks.
Ingo Lafrenz Dec. 26, 2018, 12:11 a.m. UTC | #2
Am 24.12.18 um 18:37 schrieb Dmitry Torokhov:
> On Mon, Dec 24, 2018 at 10:28:45AM +0100, Ingo Lafrenz wrote:
>> Add ELAN061A to the ACPI table to support Elan touchpad found in Lenovo
>> V130-15IGM laptops
>>
>> Signed-off-by: Ingo Lafrenz <ich+linux@der-ingo.de>
>>
>> ---
>> I have tested this successfully against the 4.19.11 kernel. Please note
>> that since kernel v4.18 the driver generates a looot of 'invalid report
>> id data (ff)' messages with this touchpad. So even the touchpad seems
>> fully functional for me there might be more to it than just adding the ID.
>> Please consider this when taking this patch, otherwise the logs will
>> be flooded with tons of messages.
> Are you saying that with this patch applied to 4.18 you do not see the
> "ff" flood? After 4.18 I only see additions of ACPI IDs to the driver,
> any chance you could bisect to see what causes invalid report messages?

Uh oh, I had a closer look at the source now and I think I have entirely
and completely misread the changes to elan_i2c_core.c before, so my above
statement that this only happens since v4.18 is probably complete and utter
garbage. For some reason I had thought the 'invalid report id data' message
was only introduced in 4.18 which is not correct at all. It's been there
before, just not inside a switch statement, but an if..else.
So I am pretty sure the flood will be there in previous kernel versions,
too, not just 4.18. I am very sorry for the confusion. :-(

So I don't think there is any need to bisect now, is there...

Anyway, to sum up:
This patch makes the ELAN061A touchpad work, but with the side effect
of generating a lot of error messages.

If there is anything else I can do, please let me know.

Cheers, Ingo =;->

Patch
diff mbox series

diff --git a/drivers/input/mouse/elan_i2c_core.c 
b/drivers/input/mouse/elan_i2c_core.c
index 2690a4b7ed53..7cacacfb90e3 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -1344,6 +1344,7 @@  static const struct acpi_device_id elan_acpi_id[] = {
      { "ELAN060B", 0 },
      { "ELAN060C", 0 },
      { "ELAN0611", 0 },
+    { "ELAN061A", 0 },
      { "ELAN1000", 0 },
      { }
  };