| Message ID | 20181226012227.70524-1-kjlu@umn.edu (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 42daad3343be4a4e1ee03e30a5f5cc731dadfef5 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | net: brcm80211: add a check for the status of usb_register | expand |
Kangjie Lu <kjlu@umn.edu> writes: > usb_register() may fail, so let's check its status and issue an error > message if it fails. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +++++- The title prefix should be "brcmfmac: " but I can fix that. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
On 1/8/2019 5:43 PM, Kalle Valo wrote: > Kangjie Lu <kjlu@umn.edu> writes: > >> usb_register() may fail, so let's check its status and issue an error >> message if it fails. >> >> Signed-off-by: Kangjie Lu <kjlu@umn.edu> >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +++++- > > The title prefix should be "brcmfmac: " but I can fix that. Hi Kalle, I wanted to ack this patch, but can not locate it in my email not in linux-wireless patchwork. Was it posted to the networking list only? Using scripts/get_maintainer.pl with the patch would reveal the lists to post to in order of preference. For wireless driver changes I refrain to linux-wireless only, but that is a personal choice I guess. Regards, Arend > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong >
Arend Van Spriel <arend.vanspriel@broadcom.com> writes: > On 1/8/2019 5:43 PM, Kalle Valo wrote: >> Kangjie Lu <kjlu@umn.edu> writes: >> >>> usb_register() may fail, so let's check its status and issue an error >>> message if it fails. >>> >>> Signed-off-by: Kangjie Lu <kjlu@umn.edu> >>> --- >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +++++- >> >> The title prefix should be "brcmfmac: " but I can fix that. > > Hi Kalle, > > I wanted to ack this patch, but can not locate it in my email not in > linux-wireless patchwork. Was it posted to the networking list only? I do see it on linux-wireless patchwork: https://patchwork.kernel.org/patch/10742769/ > Using scripts/get_maintainer.pl with the patch would reveal the lists > to post to in order of preference. For wireless driver changes I > refrain to linux-wireless only, but that is a personal choice I guess. Yeah, I guess in general wireless patches are just noise for netdev people.
Kangjie Lu <kjlu@umn.edu> wrote: > usb_register() may fail, so let's check its status and issue an error > message if it fails. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu> Patch applied to wireless-drivers-next.git, thanks. 42daad3343be brcmfmac: add a check for the status of usb_register
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c index a4308c6e72d7..76cfaf6999c8 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c @@ -1550,6 +1550,10 @@ void brcmf_usb_exit(void) void brcmf_usb_register(void) { + int ret; + brcmf_dbg(USB, "Enter\n"); - usb_register(&brcmf_usbdrvr); + ret = usb_register(&brcmf_usbdrvr); + if (ret) + brcmf_err("usb_register failed %d\n", ret); }
usb_register() may fail, so let's check its status and issue an error message if it fails. Signed-off-by: Kangjie Lu <kjlu@umn.edu> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)