| Message ID | 20181226034607.73523-1-kjlu@umn.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: add a check for sysfs_create_group | expand |
On 2018/12/26 上午11:46, Kangjie Lu wrote: > In case sysfs_create_group fails, let's check its return value and > issues an error message. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu> > --- > fs/btrfs/sysfs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c > index 3717c864ba23..62529153a51a 100644 > --- a/fs/btrfs/sysfs.c > +++ b/fs/btrfs/sysfs.c > @@ -889,6 +889,8 @@ void btrfs_sysfs_feature_update(struct btrfs_fs_info *fs_info, > */ > sysfs_remove_group(fsid_kobj, &btrfs_feature_attr_group); > ret = sysfs_create_group(fsid_kobj, &btrfs_feature_attr_group); > + if (ret) > + pr_err("failed to create btrfs_feature_attr_group.\n"); Btrfs have better error message infrastructures (e.g. distinguish different filesystems). Please use btrfs_error() or btrfs_warn() instead. Despite that, I think the patch looks good. Thanks, Qu > } > > static int btrfs_init_debugfs(void) >
diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c index 3717c864ba23..62529153a51a 100644 --- a/fs/btrfs/sysfs.c +++ b/fs/btrfs/sysfs.c @@ -889,6 +889,8 @@ void btrfs_sysfs_feature_update(struct btrfs_fs_info *fs_info, */ sysfs_remove_group(fsid_kobj, &btrfs_feature_attr_group); ret = sysfs_create_group(fsid_kobj, &btrfs_feature_attr_group); + if (ret) + pr_err("failed to create btrfs_feature_attr_group.\n"); } static int btrfs_init_debugfs(void)
In case sysfs_create_group fails, let's check its return value and issues an error message. Signed-off-by: Kangjie Lu <kjlu@umn.edu> --- fs/btrfs/sysfs.c | 2 ++ 1 file changed, 2 insertions(+)