diff mbox series

[4/6] ARM: dts: s5pv210: aries: Add reserved memory for mfc

Message ID 20181228161819.18931-5-pawel.mikolaj.chmiel@gmail.com (mailing list archive)
State Superseded
Headers show
Series ARM: dts: s5pv210: aries: Enable more drivers present on Samsung Aries based devices | expand

Commit Message

Paweł Chmiel Dec. 28, 2018, 4:18 p.m. UTC 
This commit adds memory reservation required by MFC to run.
On S5PV210 both regions needs to be on separate memory banks.
Size of both regions is taken from stock sources.

Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
---
 arch/arm/boot/dts/s5pv210-aries.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

Comments

Krzysztof Kozlowski Dec. 31, 2018, 11:44 a.m. UTC | #1 
On Fri, 28 Dec 2018 at 17:18, Paweł Chmiel
<pawel.mikolaj.chmiel@gmail.com> wrote:
>
> This commit adds memory reservation required by MFC to run.
> On S5PV210 both regions needs to be on separate memory banks.
> Size of both regions is taken from stock sources.
>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
>  arch/arm/boot/dts/s5pv210-aries.dtsi | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
> index 575094ea7024..35ba009a1a33 100644
> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
> @@ -23,6 +23,24 @@
>                         0x50000000 0x08000000>;
>         };
>
> +       reserved-memory {
> +               #address-cells = <1>;
> +               #size-cells = <1>;
> +               ranges;
> +
> +               mfc_left: region_mfc_left@43000000 {

Although you used the same naming convention as existing
exynos-mfc-reserved-memory.dtsi, the name of nodes should be generic,
so:
mfc_left: region@43000000

Best regards,
Krzysztof


> +                       compatible = "shared-dma-pool";
> +                       no-map;
> +                       reg = <0x43000000 0x2000000>;
> +               };
> +
> +               mfc_right: region_mfc_right@51000000 {
> +                       compatible = "shared-dma-pool";
> +                       no-map;
> +                       reg = <0x51000000 0x2000000>;
> +               };
> +       };
> +
>         wifi_pwrseq: wifi-pwrseq {
>                 compatible = "mmc-pwrseq-simple";
>                 reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
> @@ -329,6 +347,10 @@
>         status = "okay";
>  };
>
> +&mfc {
> +       memory-region = <&mfc_left>, <&mfc_right>;
> +};
> +
>  &pinctrl0 {
>         wlan_bt_en: wlan-bt-en {
>                 samsung,pins = "gpb-5";
> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
index 575094ea7024..35ba009a1a33 100644
--- a/arch/arm/boot/dts/s5pv210-aries.dtsi
+++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
@@ -23,6 +23,24 @@ 
 			0x50000000 0x08000000>;
 	};
 
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		mfc_left: region_mfc_left@43000000 {
+			compatible = "shared-dma-pool";
+			no-map;
+			reg = <0x43000000 0x2000000>;
+		};
+
+		mfc_right: region_mfc_right@51000000 {
+			compatible = "shared-dma-pool";
+			no-map;
+			reg = <0x51000000 0x2000000>;
+		};
+	};
+
 	wifi_pwrseq: wifi-pwrseq {
 		compatible = "mmc-pwrseq-simple";
 		reset-gpios = <&gpg1 2 GPIO_ACTIVE_LOW>;
@@ -329,6 +347,10 @@ 
 	status = "okay";
 };
 
+&mfc {
+	memory-region = <&mfc_left>, <&mfc_right>;
+};
+
 &pinctrl0 {
 	wlan_bt_en: wlan-bt-en {
 		samsung,pins = "gpb-5";