| Message ID | 20181228201119.11920-1-pakki001@umn.edu (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
| Series | dmaengine: qcom_hidma: Check for driver register failure | expand |
On Fri, Dec 28, 2018 at 11:11 PM Aditya Pakki <pakki001@umn.edu> wrote: > > While initializing the driver, the function platform_driver_register can > fail and return an error. Consistent with other invocations, this patch > returns the error upstream. > > Signed-off-by: Aditya Pakki <pakki001@umn.edu> > --- Acked-by: Sinan Kaya <okaya@kernel.org> > drivers/dma/qcom/hidma_mgmt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c > index d64edeb6771a..681de12f4c67 100644 > --- a/drivers/dma/qcom/hidma_mgmt.c > +++ b/drivers/dma/qcom/hidma_mgmt.c > @@ -423,9 +423,8 @@ static int __init hidma_mgmt_init(void) > hidma_mgmt_of_populate_channels(child); > } > #endif > - platform_driver_register(&hidma_mgmt_driver); > + return platform_driver_register(&hidma_mgmt_driver); > > - return 0; > } > module_init(hidma_mgmt_init); > MODULE_LICENSE("GPL v2"); > -- > 2.17.1 >
On 28-12-18, 14:11, Aditya Pakki wrote: > While initializing the driver, the function platform_driver_register can > fail and return an error. Consistent with other invocations, this patch > returns the error upstream. Applied, thanks
diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c index d64edeb6771a..681de12f4c67 100644 --- a/drivers/dma/qcom/hidma_mgmt.c +++ b/drivers/dma/qcom/hidma_mgmt.c @@ -423,9 +423,8 @@ static int __init hidma_mgmt_init(void) hidma_mgmt_of_populate_channels(child); } #endif - platform_driver_register(&hidma_mgmt_driver); + return platform_driver_register(&hidma_mgmt_driver); - return 0; } module_init(hidma_mgmt_init); MODULE_LICENSE("GPL v2");
While initializing the driver, the function platform_driver_register can fail and return an error. Consistent with other invocations, this patch returns the error upstream. Signed-off-by: Aditya Pakki <pakki001@umn.edu> --- drivers/dma/qcom/hidma_mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)