From patchwork Wed Jan 2 18:06:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qian Cai X-Patchwork-Id: 10746595 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 11012746 for ; Wed, 2 Jan 2019 18:07:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F23AE283BB for ; Wed, 2 Jan 2019 18:07:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E4992283EE; Wed, 2 Jan 2019 18:07:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5F6AB283BB for ; Wed, 2 Jan 2019 18:07:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95A8D8E0038; Wed, 2 Jan 2019 13:07:06 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 8E4128E0002; Wed, 2 Jan 2019 13:07:06 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AC168E0038; Wed, 2 Jan 2019 13:07:06 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by kanga.kvack.org (Postfix) with ESMTP id 49F5A8E0002 for ; Wed, 2 Jan 2019 13:07:06 -0500 (EST) Received: by mail-qt1-f197.google.com with SMTP id d35so39862199qtd.20 for ; Wed, 02 Jan 2019 10:07:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:in-reply-to:references; bh=8MMhR4sblhioJzUomNsJ/I2PWvUxrPx/Sn5DmGetoyA=; b=Sp17F9iplcFs5Ygcg9MtAynmjigYBi1vauax0vI4t/rzxIOfO1KKRW+ZNf08BC+CLw +DbPA6o5W8E3kFYYcigK7zNZBPq77FJwxr7JJscdHwYAlAByq2TQHlI5Fhbc42LAVNXK 2NH01nKjbOaOKaHniZPYnU5jqFp5+/zvW/Oqtl7JfdAqdYzz4hRcEq5U7OhJFnt4heGr uYVu4jB2KsMF3qEy3B7+aMxYp+JBMD5xZaOFLrEyXaM710RYWSXBwqPMLygqPwfrTWVw ESRuUxtns5NHrle5kbnLexsnUVBdsIcEy6bnhXV2pmxg9yBjcC90sAtrn7VTHwY47kaY ptvg== X-Gm-Message-State: AJcUukc0K2c1Umn16ooXZMwiqg3AFy1Yu4ZmBlyFqHdgbLu6WT5Y2lB2 HVfkv2/7dzG0mAYJyqQF9gNFG4N/Js4ev1dNZ/BU/KzkuyagwKTOnU3uZdv7KOUImBWmr0m+EYo B+kN+dZxPdcwkFXVVRT0UvwuZTgOwUYokJLP49w5JFRdVY+opN5xk9oWLv0Uj5J4ue46bXEdutB mYaNZsiffMJVMYPLoi4vXNeBsgsmj/DyErztdtR9rkhk3BXuq+4ZyKB8tXJEPSbcrGqztxmhX4y y1do2HkXNJK4RZfJKeSBdvxjW73SJJBuno4F9ebQU0C5dJNmmx7VObjvCuVfBYAJeFIf3OwLMaU nWqlBCukhJ/4kyVNIOTknfX3YUmYPsqYCU0RCAbbE4Mk03KlRH1e09AsENnWtOKg+xi//oLhl2E D X-Received: by 2002:a0c:e2ca:: with SMTP id t10mr45049868qvl.77.1546452426038; Wed, 02 Jan 2019 10:07:06 -0800 (PST) X-Received: by 2002:a0c:e2ca:: with SMTP id t10mr45049839qvl.77.1546452425485; Wed, 02 Jan 2019 10:07:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546452425; cv=none; d=google.com; s=arc-20160816; b=bNsb1OJX4c1pGhzHhsf9rWbgxFUi04bsIh64QtK9RUUANQHZvjsb/3Z6u7WoaM0hOS aurNLI1d0GDKryvCFKdXuyypnL7TjPOYJJIdXprIGcGVxg7VG57i8NPpT3FgfAP/esPC RdDDD8U7gZLzPF5btjoieXsfVLS//DR5zbydKZQzvk72hd27YAqTElDCqAYV4c2mncWA 8UHtUKy9+a3AyW2QR0mwQsZMxZI7u3hyxwGNX3C+3ywzp7iLqG+NNb42zdVB09F0q597 o8anKXigON9Akg+Mlo7dBsOT4BxoFbIgPhS2wSYLlEcVWK9Dut5tI5CgGvmaD6Gr/Kv4 ecBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8MMhR4sblhioJzUomNsJ/I2PWvUxrPx/Sn5DmGetoyA=; b=ElSypy6vxujI6vcuS2RZLJkYG0TuUOcAdVAIaE2CxmV51AprL4vYCF91W8NIY/OROO 1mJcEVCzfevUIboLoO8XBqRRIdNQ1PNhIkZL+QUJU+PjdgL4RyUkSLfqAiHrtD3Xj5/8 uLMRdUzNRHRhn1R2CfrhQE7woNQOr1uNikBezr3Qvk4uhpJ0k2QPj+n1iuqgAbAj3oS8 lJ9WzSf+iDwwnfaFmo2kiDHffHvk5Mxp+qLNAcItcR3rYulHb931wIr7OcxdF0JTvacD vST2xlyAZxW5WwzZyRYOWuLCNG3mx7spip/YRMOm5OWc3R7MwcF5G8s3m/xzI4iI2qN7 64Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=WI9X1XQz; spf=pass (google.com: domain of cai@lca.pw designates 209.85.220.65 as permitted sender) smtp.mailfrom=cai@lca.pw Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id c135sor22113437qka.63.2019.01.02.10.07.05 for (Google Transport Security); Wed, 02 Jan 2019 10:07:05 -0800 (PST) Received-SPF: pass (google.com: domain of cai@lca.pw designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=WI9X1XQz; spf=pass (google.com: domain of cai@lca.pw designates 209.85.220.65 as permitted sender) smtp.mailfrom=cai@lca.pw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8MMhR4sblhioJzUomNsJ/I2PWvUxrPx/Sn5DmGetoyA=; b=WI9X1XQz1cEWUVgamTBHZcl3PQGgqDRDzpXDrsx+G5yIjjab4UqzZJ1PufW3xKw29B nsllIBrjMpBqRDWhWn/z5dNKq+BTx4Ho9Ho3i0bneu9CuA6rJ7/GbXhSW5wvhgKVdRVG LVZoTWCBas8/Y9ck0JdKd4pEa1/tVVLzQsv0cmpXRcyzOEb26aK5tnw6lAe/vQbdwEsm +SKtD5vc/f7oBzpBz3aqAsfW50ITxNGhgE0H0rfbMS9kYitq+F4AuXZETpD31KrnuDdw skAi1YrJYMo1QZwNDQgew5NYc0saNIIKflc4XrbvweXrMYrT4ies0F1id4CYO7YA+UNX rMWA== X-Google-Smtp-Source: ALg8bN55wjlWgpEnZeB50u7PpcQBjVNz4nbpZukoG+mAzwR0FtKM7suKPI+Wa/vrT/HimRArfkXlTw== X-Received: by 2002:a37:ae87:: with SMTP id x129mr42158644qke.15.1546452425245; Wed, 02 Jan 2019 10:07:05 -0800 (PST) Received: from ovpn-120-55.rdu2.redhat.com (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id u67sm23243069qki.22.2019.01.02.10.07.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Jan 2019 10:07:04 -0800 (PST) From: Qian Cai To: catalin.marinas@arm.com Cc: akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH v2] kmemleak: survive in a low-memory situation Date: Wed, 2 Jan 2019 13:06:19 -0500 Message-Id: <20190102180619.12392-1-cai@lca.pw> X-Mailer: git-send-email 2.17.2 (Apple Git-113) In-Reply-To: <20190102165931.GB6584@arrakis.emea.arm.com> References: <20190102165931.GB6584@arrakis.emea.arm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Kmemleak could quickly fail to allocate an object structure and then disable itself in a low-memory situation. For example, running a mmap() workload triggering swapping and OOM [1]. Kmemleak allocation could fail even though the trackig object is succeeded. Hence, it could still try to start a direct reclaim if it is not executed in an atomic context (spinlock, irq-handler etc), or a high-priority allocation in an atomic context as a last-ditch effort. [1] https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/mem/oom/oom01.c Signed-off-by: Qian Cai --- v2: remove the needless checking for NULL objects in slab_post_alloc_hook() pointed out by Catalin. mm/kmemleak.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index f9d9dc250428..9e1aa3b7df75 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -576,6 +576,16 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size, struct rb_node **link, *rb_parent; object = kmem_cache_alloc(object_cache, gfp_kmemleak_mask(gfp)); +#ifdef CONFIG_PREEMPT_COUNT + if (!object) { + /* last-ditch effort in a low-memory situation */ + if (irqs_disabled() || is_idle_task(current) || in_atomic()) + gfp = GFP_ATOMIC; + else + gfp = gfp_kmemleak_mask(gfp) | __GFP_DIRECT_RECLAIM; + object = kmem_cache_alloc(object_cache, gfp); + } +#endif if (!object) { pr_warn("Cannot allocate a kmemleak_object structure\n"); kmemleak_disable();