From patchwork Fri Jan 4 12:49:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mel Gorman X-Patchwork-Id: 10748299 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0D69A13B5 for ; Fri, 4 Jan 2019 12:50:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EFD72283C9 for ; Fri, 4 Jan 2019 12:50:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DE73A28434; Fri, 4 Jan 2019 12:50:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 03027283C9 for ; Fri, 4 Jan 2019 12:50:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D8538E00D5; Fri, 4 Jan 2019 07:50:45 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 187848E00AE; Fri, 4 Jan 2019 07:50:45 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A00C8E00D5; Fri, 4 Jan 2019 07:50:45 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by kanga.kvack.org (Postfix) with ESMTP id A4F288E00AE for ; Fri, 4 Jan 2019 07:50:44 -0500 (EST) Received: by mail-ed1-f72.google.com with SMTP id d41so34696447eda.12 for ; Fri, 04 Jan 2019 04:50:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=SjNbp0igOurjj96TnaHeZWGR5AZ0iL/+N2T6YDn5F3c=; b=nZiAwIN/1FhxiafPj+MkWDK5Wt/VSIgGpy1p+0uuoQkWZNanCu3iSlIxxJdmmEZ2JK VP5p7vIpKQxWDDNQwiohaZJB/9BSfgR4ZHfaFPUTMmzOTQXIineBNUw79hKQVoczG5U8 j7kksNiGcXSwBJj2HkJCMTtwohTyJTALVrEc4h0EJXFhpUSgmirxX7KCHWig2xSodkuN hWKE9FzsWP6NkPN9antdTOjSSQGmBr/9esG6x5AY6nuh7icDF55U0uVEx66EqfX+5hhy CsLKPVoiqgfheoqeaQKMa9IXYPQ4JVc9kPWTmVRZsdej5TbyBcK0+gl48O2qlM+nGio1 1ScQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of mgorman@techsingularity.net designates 81.17.249.8 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Gm-Message-State: AA+aEWZf3diKxODef6c7McUSMMfRStolZwHHi6hqa9WfzRe+d/zSfwCe yKChwhXtwJygMPaFevBOxfJd8xjjhvWVZnmhMa+VCvgjSrbp76cTSddWawA8ltWtFxLBWZYIJvb JlgDGfMzWQjk22SifzSg6z68/nVcr9/S4bjP5U1mzpyAolajCBpyWHhwECIuR8Ycxkw== X-Received: by 2002:a17:906:d054:: with SMTP id bo20-v6mr39001139ejb.239.1546606244171; Fri, 04 Jan 2019 04:50:44 -0800 (PST) X-Google-Smtp-Source: AFSGD/U2AxY4PQ5htpieMY2mqc6fpJrDFQdm9qNDi0QS6JbftwY0XCK8ris8kDQHjcLzqVstwORD X-Received: by 2002:a17:906:d054:: with SMTP id bo20-v6mr39001097ejb.239.1546606243058; Fri, 04 Jan 2019 04:50:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546606243; cv=none; d=google.com; s=arc-20160816; b=FE0Kv02H2UxwwpwLIaVDAeGLWAkxuwsDNYRLFIHCONfDh336kf3pRdkxj89s0ENflj y0oVkmLxjmdmW3gM4Rq/MnnfgJEMDfVb8QRn3K6LOMujiHsqF+e0+pt4c0jfkdhF2o6e MCvQf7CVuA/PlCBaHZr71U+ycXHYWUjn3eQJ28WtNbKOL0N67so6/niAWsJmmLdeZjP8 rHg8dqGOde/ZG3N3AJzmdqijYKDT43BCKr0XemZfQlNaV0bZq0lw9AcVhk9uff8JfJfN gC9oHbz+qNHZhWToKSMS3pafB49TT27XT/xgoz+eNhYdulmYTshyIWZCLel3CPyvqWSk YETw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=SjNbp0igOurjj96TnaHeZWGR5AZ0iL/+N2T6YDn5F3c=; b=I/SQBm9uW+kFvVWFsSrWOGNT/RwGR/1tzjEMibbAdcalFqdwKbphCbnzQIg/i4rr2b GAqznfyz4i4zOGMAkoIhY2FI/xdm3qwppTnh8fxMP0KVROnIUxdjKYVxCMzMnQOJFJOY er3ACooXTaOEaGWtN3WX797JkHv59IYsrvrHbHV+LsITpiRgeSBv9q/p/e1hHwArONCv 28F30Exk35B0Pg3+akMTatczWWbjq4G01zNQw63A7JxB1P1h7JrmNA/LI0mwUQguMKQw EZzimS0kTu7BSlChj4vl5imCyrs1FamdrtDjnBCNBF030vDoGMQdyo+0gAowHeTlPsCl Qi0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of mgorman@techsingularity.net designates 81.17.249.8 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net Received: from outbound-smtp02.blacknight.com (outbound-smtp02.blacknight.com. [81.17.249.8]) by mx.google.com with ESMTPS id q23si3893731eds.78.2019.01.04.04.50.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Jan 2019 04:50:43 -0800 (PST) Received-SPF: pass (google.com: domain of mgorman@techsingularity.net designates 81.17.249.8 as permitted sender) client-ip=81.17.249.8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of mgorman@techsingularity.net designates 81.17.249.8 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp02.blacknight.com (Postfix) with ESMTPS id 9CC0D9855B for ; Fri, 4 Jan 2019 12:50:42 +0000 (UTC) Received: (qmail 29960 invoked from network); 4 Jan 2019 12:50:42 -0000 Received: from unknown (HELO stampy.163woodhaven.lan) (mgorman@techsingularity.net@[37.228.229.96]) by 81.17.254.9 with ESMTPA; 4 Jan 2019 12:50:42 -0000 From: Mel Gorman To: Linux-MM Cc: David Rientjes , Andrea Arcangeli , Vlastimil Babka , ying.huang@intel.com, kirill@shutemov.name, Andrew Morton , Linux List Kernel Mailing , Mel Gorman Subject: [PATCH 02/25] mm, compaction: Rearrange compact_control Date: Fri, 4 Jan 2019 12:49:48 +0000 Message-Id: <20190104125011.16071-3-mgorman@techsingularity.net> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190104125011.16071-1-mgorman@techsingularity.net> References: <20190104125011.16071-1-mgorman@techsingularity.net> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP compact_control spans two cache lines with write-intensive lines on both. Rearrange so the most write-intensive fields are in the same cache line. This has a negligible impact on the overall performance of compaction and is more a tidying exercise than anything. Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka --- mm/internal.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index 5ddf5d3771a0..9437ba5791db 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -183,14 +183,14 @@ extern int user_min_free_kbytes; struct compact_control { struct list_head freepages; /* List of free pages to migrate to */ struct list_head migratepages; /* List of pages being migrated */ - struct zone *zone; unsigned int nr_freepages; /* Number of isolated free pages */ unsigned int nr_migratepages; /* Number of pages to migrate */ - unsigned long total_migrate_scanned; - unsigned long total_free_scanned; unsigned long free_pfn; /* isolate_freepages search base */ unsigned long migrate_pfn; /* isolate_migratepages search base */ unsigned long last_migrated_pfn;/* Not yet flushed page being freed */ + struct zone *zone; + unsigned long total_migrate_scanned; + unsigned long total_free_scanned; const gfp_t gfp_mask; /* gfp mask of a direct compactor */ int order; /* order a direct compactor needs */ int migratetype; /* migratetype of direct compactor */