Revert "common/config: create $RESULT_BASE before dumping kmemleak leaks"
diff mbox series

Message ID 20190104143116.5698-1-nborisov@suse.com
State New
Headers show
Series
  • Revert "common/config: create $RESULT_BASE before dumping kmemleak leaks"
Related show

Commit Message

Nikolay Borisov Jan. 4, 2019, 2:31 p.m. UTC
This commit tried to fix the brokennes of the kmemleak support but it 
inadvertently broke the creation of the RESULT_BASE directory which lead to 
problems creating check.time file. Turns out kmemleak support in xfstests has 
more problems and it needs to be majorly refactor and this commit doesn't 
really solve the problem. For the time being just revert to at least allow 
older configuration files, which have explicitly set RESULT_BASE to work. 

This reverts commit 7fc034868d5dce9aaf3517c9c2197221b9a772e4.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 check         | 7 +++++++
 common/config | 5 -----
 2 files changed, 7 insertions(+), 5 deletions(-)

Patch
diff mbox series

diff --git a/check b/check
index e4d767375b57..77a06b00dbba 100755
--- a/check
+++ b/check
@@ -538,6 +538,13 @@  for section in $HOST_OPTIONS_SECTIONS; do
 		fi
 	fi
 
+	mkdir -p $RESULT_BASE
+	if [ ! -d $RESULT_BASE ]; then
+		echo "failed to create results directory $RESULT_BASE"
+		status=1
+		exit
+	fi
+
 	if $OPTIONS_HAVE_SECTIONS; then
 		echo "SECTION       -- $section"
 	fi
diff --git a/common/config b/common/config
index fb664cf0a967..5b48e1e7323b 100644
--- a/common/config
+++ b/common/config
@@ -663,11 +663,6 @@  get_next_config() {
 	# set default RESULT_BASE
 	if [ -z "$RESULT_BASE" ]; then
 		export RESULT_BASE="$here/results/"
-		mkdir -p ${RESULT_BASE}
-		if [ ! -d ${RESULT_BASE} ]; then
-			echo "failed to create results directory $RESULT_BASE"
-			exit 1
-		fi
 	fi
 
 	if [ "$FSTYP" == "tmpfs" ]; then