| Message ID | 20190104175847.6290-9-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw: Remove "hw/devices.h" | expand |
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index f571b29077..03872552ee 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -640,6 +640,7 @@ M: Peter Maydell <peter.maydell@linaro.org> > L: qemu-arm@nongnu.org > S: Odd Fixes > F: hw/arm/nseries.c > +F: hw/input/tsc2*.c > F: include/hw/display/blizzard.h > F: include/hw/misc/cbus.h > > @@ -649,6 +650,7 @@ M: Peter Maydell <peter.maydell@linaro.org> > L: qemu-arm@nongnu.org > S: Odd Fixes > F: hw/arm/palm.c > +F: hw/input/tsc2*.c The Palm machine does not seem to use tsc2005, does it? So I think this entry here is wrong. Thomas
Hi Thomas, On 1/7/19 8:18 AM, Thomas Huth wrote: > On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> --- >> MAINTAINERS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index f571b29077..03872552ee 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -640,6 +640,7 @@ M: Peter Maydell <peter.maydell@linaro.org> >> L: qemu-arm@nongnu.org >> S: Odd Fixes >> F: hw/arm/nseries.c >> +F: hw/input/tsc2*.c >> F: include/hw/display/blizzard.h >> F: include/hw/misc/cbus.h >> >> @@ -649,6 +650,7 @@ M: Peter Maydell <peter.maydell@linaro.org> >> L: qemu-arm@nongnu.org >> S: Odd Fixes >> F: hw/arm/palm.c >> +F: hw/input/tsc2*.c > > The Palm machine does not seem to use tsc2005, does it? So I think this > entry here is wrong. It does use another touchscreen controller, the tsc2102, which in the next patch are declared in the same header (you suggested "tsc2xxx.h): $ git grep tsc2.*init hw/arm/ hw/arm/nseries.c:284: s->ts.chip = tsc2301_init(penirq, kbirq, dav); hw/arm/nseries.c:306: s->ts.opaque = tsc2005_init(pintdav); hw/arm/palm.c:88: tsc = tsc2102_init(qdev_get_gpio_in(cpu->gpio, PALMTE_PINTDAV_GPIO));
On 2019-01-07 09:02, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 1/7/19 8:18 AM, Thomas Huth wrote: >> On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >>> --- >>> MAINTAINERS | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index f571b29077..03872552ee 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -640,6 +640,7 @@ M: Peter Maydell <peter.maydell@linaro.org> >>> L: qemu-arm@nongnu.org >>> S: Odd Fixes >>> F: hw/arm/nseries.c >>> +F: hw/input/tsc2*.c >>> F: include/hw/display/blizzard.h >>> F: include/hw/misc/cbus.h >>> >>> @@ -649,6 +650,7 @@ M: Peter Maydell <peter.maydell@linaro.org> >>> L: qemu-arm@nongnu.org >>> S: Odd Fixes >>> F: hw/arm/palm.c >>> +F: hw/input/tsc2*.c >> >> The Palm machine does not seem to use tsc2005, does it? So I think this >> entry here is wrong. > > It does use another touchscreen controller, the tsc2102, which in the > next patch are declared in the same header (you suggested "tsc2xxx.h): So using the tsc2*.c wildcard for the *C* file is still wrong here, isn't it? Thomas
On 1/7/19 9:05 AM, Thomas Huth wrote: > On 2019-01-07 09:02, Philippe Mathieu-Daudé wrote: >> Hi Thomas, >> >> On 1/7/19 8:18 AM, Thomas Huth wrote: >>> On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: >>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >>>> --- >>>> MAINTAINERS | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index f571b29077..03872552ee 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -640,6 +640,7 @@ M: Peter Maydell <peter.maydell@linaro.org> >>>> L: qemu-arm@nongnu.org >>>> S: Odd Fixes >>>> F: hw/arm/nseries.c >>>> +F: hw/input/tsc2*.c >>>> F: include/hw/display/blizzard.h >>>> F: include/hw/misc/cbus.h >>>> >>>> @@ -649,6 +650,7 @@ M: Peter Maydell <peter.maydell@linaro.org> >>>> L: qemu-arm@nongnu.org >>>> S: Odd Fixes >>>> F: hw/arm/palm.c >>>> +F: hw/input/tsc2*.c >>> >>> The Palm machine does not seem to use tsc2005, does it? So I think this >>> entry here is wrong. >> >> It does use another touchscreen controller, the tsc2102, which in the >> next patch are declared in the same header (you suggested "tsc2xxx.h): > > So using the tsc2*.c wildcard for the *C* file is still wrong here, > isn't it? Oh I got it now! Yes, you are right :) I'll update.
diff --git a/MAINTAINERS b/MAINTAINERS index f571b29077..03872552ee 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -640,6 +640,7 @@ M: Peter Maydell <peter.maydell@linaro.org> L: qemu-arm@nongnu.org S: Odd Fixes F: hw/arm/nseries.c +F: hw/input/tsc2*.c F: include/hw/display/blizzard.h F: include/hw/misc/cbus.h @@ -649,6 +650,7 @@ M: Peter Maydell <peter.maydell@linaro.org> L: qemu-arm@nongnu.org S: Odd Fixes F: hw/arm/palm.c +F: hw/input/tsc2*.c Raspberry Pi M: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+)