| Message ID | 20190109124312.10154-1-faiz_abbas@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: Fix Kconfig warnings on keystone_defconfig | expand |
On Wed, Jan 09, 2019 at 06:13:12PM +0530, Faiz Abbas wrote: > Commit 961de0a856e3 ("mmc: sdhci-omap: Workaround errata regarding > SDR104/HS200 tuning failures (i929)") added a select on TI_SOC_THERMAL > for the driver to get temperature for tuning. > > However, this causes the following warning on keystone_defconfig because > keystone does not support TI_SOC_THERMAL: > > "WARNING: unmet direct dependencies detected for TI_SOC_THERMAL" > > Fix this by changing the select to imply. > > Fixes: 961de0a856e3 ("mmc: sdhci-omap: Workaround errata regarding > SDR104/HS200 tuning failures (i929)") > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index e26b8145efb3..bc61eefcb695 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -978,7 +978,7 @@ config MMC_SDHCI_OMAP > tristate "TI SDHCI Controller Support" > depends on MMC_SDHCI_PLTFM && OF > select THERMAL > - select TI_SOC_THERMAL > + imply TI_SOC_THERMAL > help > This selects the Secure Digital Host Controller Interface (SDHCI) > support present in TI's DRA7 SOCs. The controller supports > -- Fixes the warnings I'm seeing with randconfig builds. Tested-by: Borislav Petkov <bp@suse.de>
On 9/01/19 2:43 PM, Faiz Abbas wrote: > Commit 961de0a856e3 ("mmc: sdhci-omap: Workaround errata regarding > SDR104/HS200 tuning failures (i929)") added a select on TI_SOC_THERMAL > for the driver to get temperature for tuning. > > However, this causes the following warning on keystone_defconfig because > keystone does not support TI_SOC_THERMAL: > > "WARNING: unmet direct dependencies detected for TI_SOC_THERMAL" > > Fix this by changing the select to imply. > > Fixes: 961de0a856e3 ("mmc: sdhci-omap: Workaround errata regarding > SDR104/HS200 tuning failures (i929)") > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index e26b8145efb3..bc61eefcb695 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -978,7 +978,7 @@ config MMC_SDHCI_OMAP > tristate "TI SDHCI Controller Support" > depends on MMC_SDHCI_PLTFM && OF > select THERMAL > - select TI_SOC_THERMAL > + imply TI_SOC_THERMAL > help > This selects the Secure Digital Host Controller Interface (SDHCI) > support present in TI's DRA7 SOCs. The controller supports >
On Wed, 9 Jan 2019 at 13:40, Faiz Abbas <faiz_abbas@ti.com> wrote: > > Commit 961de0a856e3 ("mmc: sdhci-omap: Workaround errata regarding > SDR104/HS200 tuning failures (i929)") added a select on TI_SOC_THERMAL > for the driver to get temperature for tuning. > > However, this causes the following warning on keystone_defconfig because > keystone does not support TI_SOC_THERMAL: > > "WARNING: unmet direct dependencies detected for TI_SOC_THERMAL" > > Fix this by changing the select to imply. > > Fixes: 961de0a856e3 ("mmc: sdhci-omap: Workaround errata regarding > SDR104/HS200 tuning failures (i929)") > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> Applied for fixes, thanks! Kind regards Uffe > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index e26b8145efb3..bc61eefcb695 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -978,7 +978,7 @@ config MMC_SDHCI_OMAP > tristate "TI SDHCI Controller Support" > depends on MMC_SDHCI_PLTFM && OF > select THERMAL > - select TI_SOC_THERMAL > + imply TI_SOC_THERMAL > help > This selects the Secure Digital Host Controller Interface (SDHCI) > support present in TI's DRA7 SOCs. The controller supports > -- > 2.19.2 >
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index e26b8145efb3..bc61eefcb695 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -978,7 +978,7 @@ config MMC_SDHCI_OMAP tristate "TI SDHCI Controller Support" depends on MMC_SDHCI_PLTFM && OF select THERMAL - select TI_SOC_THERMAL + imply TI_SOC_THERMAL help This selects the Secure Digital Host Controller Interface (SDHCI) support present in TI's DRA7 SOCs. The controller supports
Commit 961de0a856e3 ("mmc: sdhci-omap: Workaround errata regarding SDR104/HS200 tuning failures (i929)") added a select on TI_SOC_THERMAL for the driver to get temperature for tuning. However, this causes the following warning on keystone_defconfig because keystone does not support TI_SOC_THERMAL: "WARNING: unmet direct dependencies detected for TI_SOC_THERMAL" Fix this by changing the select to imply. Fixes: 961de0a856e3 ("mmc: sdhci-omap: Workaround errata regarding SDR104/HS200 tuning failures (i929)") Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> --- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)