diff mbox series

megaraid_sas: Retry reads of outbound_intr_status reg

Message ID 1547039317-1421-1-git-send-email-shivasharan.srikanteshwara@broadcom.com (mailing list archive)
State Mainlined
Commit c65bfc8163696dd171e081488b0321beb630b708
Headers show
Series megaraid_sas: Retry reads of outbound_intr_status reg | expand

Commit Message

Shivasharan S Jan. 9, 2019, 1:08 p.m. UTC 
commit 272652fcbf1a ("scsi: megaraid_sas: add retry logic in megasas_readl")
missed changing readl to megasas_readl in megasas_clear_intr_fusion().
For Aero controllers, reads of outbound_intr_status register needs to
be retried.

Reported-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Martin K. Petersen Jan. 12, 2019, 3:26 a.m. UTC | #1 
Shivasharan,

> commit 272652fcbf1a ("scsi: megaraid_sas: add retry logic in megasas_readl")
> missed changing readl to megasas_readl in megasas_clear_intr_fusion().
> For Aero controllers, reads of outbound_intr_status register needs to
> be retried.

Applied to 5.0/scsi-fixes, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 211c17c33aa0..2665dbdcf2f8 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -175,7 +175,8 @@  megasas_clear_intr_fusion(struct megasas_instance *instance)
 	/*
 	 * Check if it is our interrupt
 	 */
-	status = readl(&regs->outbound_intr_status);
+	status = megasas_readl(instance,
+			       &regs->outbound_intr_status);
 
 	if (status & 1) {
 		writel(status, &regs->outbound_intr_status);