generic/423: statx mask of the reference file is different from the original file
diff mbox series

Message ID 1547090099-8394-1-git-send-email-cuiyue-fnst@cn.fujitsu.com
State New
Headers show
Series
  • generic/423: statx mask of the reference file is different from the original file
Related show

Commit Message

Cui, Yue Jan. 10, 2019, 3:14 a.m. UTC
When running xfstests generic/423 to test system call statx() on hard link files of NFS, it fails.
error message:
[!] attr 'stx_mask' differs from ref file, 7ff != e0

The values of parameter "mask" between the original file and the reference file are different.
One is STATX_ALL;
The other is STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME.

Modify the function get_reference() to pass the "mask" in,
and change STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME to "mask".
---
 src/stat_test.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Eryu Guan Jan. 10, 2019, 8:35 a.m. UTC | #1
On Wed, Jan 09, 2019 at 10:14:59PM -0500, Cui Yue wrote:
> When running xfstests generic/423 to test system call statx() on hard link files of NFS, it fails.
> error message:
> [!] attr 'stx_mask' differs from ref file, 7ff != e0
> 
> The values of parameter "mask" between the original file and the reference file are different.
> One is STATX_ALL;
> The other is STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME.
> 
> Modify the function get_reference() to pass the "mask" in,
> and change STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME to "mask".

Thanks for the fix! Patch looks fine to me, but please follow the kernel
rules for submitting patches in the future. The commit log has too long
lines and you're missing Signed-off-by tag. I'll do the update at commit
time, no need to resend.

Thanks,
Eryu
Eryu Guan Jan. 11, 2019, 2:58 a.m. UTC | #2
On Thu, Jan 10, 2019 at 04:35:49PM +0800, Eryu Guan wrote:
> On Wed, Jan 09, 2019 at 10:14:59PM -0500, Cui Yue wrote:
> > When running xfstests generic/423 to test system call statx() on hard link files of NFS, it fails.
> > error message:
> > [!] attr 'stx_mask' differs from ref file, 7ff != e0
> > 
> > The values of parameter "mask" between the original file and the reference file are different.
> > One is STATX_ALL;
> > The other is STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME.
> > 
> > Modify the function get_reference() to pass the "mask" in,
> > and change STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME to "mask".
> 
> Thanks for the fix! Patch looks fine to me, but please follow the kernel
> rules for submitting patches in the future. The commit log has too long
> lines and you're missing Signed-off-by tag. I'll do the update at commit

As remindered by Darrick (thanks Darrick!), I need an explicit SOB tag
from you. Could You please either resend the patch with proper SOB tag
or provide the SOB tag by replying this thread?

Thanks,
Eryu
Cui, Yue Jan. 11, 2019, 5:32 a.m. UTC | #3
Signed-off-by: Cui Yue <cuiyue-fnst@cn.fujitsu.com

Thanks a lot
Cui Yue
>
> -----Original Message-----
> From: Eryu Guan [mailto:guaneryu@gmail.com]
> Sent: Friday, January 11, 2019 10:58 AM
> To: Cui, Yue/崔 悦 <cuiyue-fnst@cn.fujitsu.com>
> Cc: fstests@vger.kernel.org
> Subject: Re: [PATCH] generic/423: statx mask of the reference file is different
> from the original file
> 
> On Thu, Jan 10, 2019 at 04:35:49PM +0800, Eryu Guan wrote:
> > On Wed, Jan 09, 2019 at 10:14:59PM -0500, Cui Yue wrote:
> > > When running xfstests generic/423 to test system call statx() on hard link
> files of NFS, it fails.
> > > error message:
> > > [!] attr 'stx_mask' differs from ref file, 7ff != e0
> > >
> > > The values of parameter "mask" between the original file and the reference
> file are different.
> > > One is STATX_ALL;
> > > The other is STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME.
> > >
> > > Modify the function get_reference() to pass the "mask" in, and
> > > change STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME to
> "mask".
> >
> > Thanks for the fix! Patch looks fine to me, but please follow the
> > kernel rules for submitting patches in the future. The commit log has
> > too long lines and you're missing Signed-off-by tag. I'll do the
> > update at commit
> 
> As remindered by Darrick (thanks Darrick!), I need an explicit SOB tag from you.
> Could You please either resend the patch with proper SOB tag or provide the
> SOB tag by replying this thread?
> 
> Thanks,
> Eryu
>

Patch
diff mbox series

diff --git a/src/stat_test.c b/src/stat_test.c
index 94c20d6..95cfdc4 100644
--- a/src/stat_test.c
+++ b/src/stat_test.c
@@ -290,7 +290,7 @@  static void set_origin_timestamp(const char *arg)
 /*
  * Get reference stats from a file.
  */
-static void get_reference(const char *file)
+static void get_reference(const char *file, unsigned int mask)
 {
 	int ret;
 
@@ -298,9 +298,7 @@  static void get_reference(const char *file)
 		bad_arg("ref= requires a filename\n");
 
 	memset(&ref, 0xfb, sizeof(ref));
-	ret = xfstests_statx(AT_FDCWD, file, AT_SYMLINK_NOFOLLOW,
-			     STATX_ATIME | STATX_BTIME | STATX_CTIME | STATX_MTIME,
-			     &ref);
+	ret = xfstests_statx(AT_FDCWD, file, AT_SYMLINK_NOFOLLOW, mask, &ref);
 	switch (ret) {
 	case 0:
 		ref_set = true;
@@ -751,7 +749,7 @@  int main(int argc, char **argv)
 
 		if (strncmp("ref=", arg, 4) == 0) {
 			/* ref=<file> - set reference stats from file */
-			get_reference(arg + 4);
+			get_reference(arg + 4, mask);
 			continue;
 		}