[1/5] ALSA: hda: add verbs for stripe control
diff mbox series

Message ID 1547139805-1904-1-git-send-email-spujar@nvidia.com
State New
Headers show
Series
  • [1/5] ALSA: hda: add verbs for stripe control
Related show

Commit Message

Sameer Pujar Jan. 10, 2019, 5:03 p.m. UTC
Controllers can support multiple Serial Data Out(SDO) lines, for
extended outbound bandwidth, to pump data to all codecs on the link.
Codecs can sample data present on SDO.

Add verbs AC_VERB_GET_STRIPE_CONTROL and AC_VERB_SET_STRIPE_CONTROL
These can be used to program usage of SDO lines for codec.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
Reviewed-by: Mohan Kumar D <mkumard@nvidia.com>
Reviewed-by: Ravindra Lokhande <rlokhande@nvidia.com>
---
 include/sound/hda_verbs.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Takashi Iwai Jan. 11, 2019, 11:22 a.m. UTC | #1
On Thu, 10 Jan 2019 18:03:21 +0100,
Sameer Pujar wrote:
> 
> Controllers can support multiple Serial Data Out(SDO) lines, for
> extended outbound bandwidth, to pump data to all codecs on the link.
> Codecs can sample data present on SDO.
> 
> Add verbs AC_VERB_GET_STRIPE_CONTROL and AC_VERB_SET_STRIPE_CONTROL
> These can be used to program usage of SDO lines for codec.
> 
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Reviewed-by: Mohan Kumar D <mkumard@nvidia.com>
> Reviewed-by: Ravindra Lokhande <rlokhande@nvidia.com>

Could you put a cover letter at the next submission?


thanks,

Takashi
Sameer Pujar Jan. 11, 2019, 11:30 a.m. UTC | #2
On 1/11/2019 4:52 PM, Takashi Iwai wrote:
> On Thu, 10 Jan 2019 18:03:21 +0100,
> Sameer Pujar wrote:
>> Controllers can support multiple Serial Data Out(SDO) lines, for
>> extended outbound bandwidth, to pump data to all codecs on the link.
>> Codecs can sample data present on SDO.
>>
>> Add verbs AC_VERB_GET_STRIPE_CONTROL and AC_VERB_SET_STRIPE_CONTROL
>> These can be used to program usage of SDO lines for codec.
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> Reviewed-by: Mohan Kumar D <mkumard@nvidia.com>
>> Reviewed-by: Ravindra Lokhande <rlokhande@nvidia.com>
> Could you put a cover letter at the next submission?

Sorry for the naive question.
Could you please point me to a reference how cover letter for a patch 
should look like?

Thanks,
Sameer.

>
> thanks,
>
> Takashi

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
Takashi Iwai Jan. 11, 2019, 11:47 a.m. UTC | #3
On Fri, 11 Jan 2019 12:30:34 +0100,
Sameer Pujar wrote:
> 
> 
> On 1/11/2019 4:52 PM, Takashi Iwai wrote:
> > On Thu, 10 Jan 2019 18:03:21 +0100,
> > Sameer Pujar wrote:
> >> Controllers can support multiple Serial Data Out(SDO) lines, for
> >> extended outbound bandwidth, to pump data to all codecs on the link.
> >> Codecs can sample data present on SDO.
> >>
> >> Add verbs AC_VERB_GET_STRIPE_CONTROL and AC_VERB_SET_STRIPE_CONTROL
> >> These can be used to program usage of SDO lines for codec.
> >>
> >> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> >> Reviewed-by: Mohan Kumar D <mkumard@nvidia.com>
> >> Reviewed-by: Ravindra Lokhande <rlokhande@nvidia.com>
> > Could you put a cover letter at the next submission?
> 
> Sorry for the naive question.
> Could you please point me to a reference how cover letter for a patch
> should look like?

An easy way would be to create it via git format-patch --cover-letter
option.  Then describe what this patchset provides, and more
importantly, why this is needed.  More background that isn't included
in each patch description, or some additional notes, as well as the
information like what's different from the previous submission can be
put there.

Look through ML archives.  The post with "[PATCH 0/N]" is usually a
cover letter.

Also, for the second submission, don't forget to put a version number
to the subject prefix, e.g. [PATCH v2 0/5].


HTH,

Takashi

Patch
diff mbox series

diff --git a/include/sound/hda_verbs.h b/include/sound/hda_verbs.h
index 2a8573a..e36b775 100644
--- a/include/sound/hda_verbs.h
+++ b/include/sound/hda_verbs.h
@@ -66,6 +66,7 @@  enum {
 #define AC_VERB_GET_CONFIG_DEFAULT		0x0f1c
 /* f20: AFG/MFG */
 #define AC_VERB_GET_SUBSYSTEM_ID		0x0f20
+#define AC_VERB_GET_STRIPE_CONTROL		0x0f24
 #define AC_VERB_GET_CVT_CHAN_COUNT		0x0f2d
 #define AC_VERB_GET_HDMI_DIP_SIZE		0x0f2e
 #define AC_VERB_GET_HDMI_ELDD			0x0f2f
@@ -110,6 +111,7 @@  enum {
 #define AC_VERB_SET_CONFIG_DEFAULT_BYTES_3	0x71f
 #define AC_VERB_SET_EAPD				0x788
 #define AC_VERB_SET_CODEC_RESET			0x7ff
+#define AC_VERB_SET_STRIPE_CONTROL		0x724
 #define AC_VERB_SET_CVT_CHAN_COUNT		0x72d
 #define AC_VERB_SET_HDMI_DIP_INDEX		0x730
 #define AC_VERB_SET_HDMI_DIP_DATA		0x731