From patchwork Thu Jan 10 22:24:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Shilovsky X-Patchwork-Id: 10757013 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6464F1399 for ; Thu, 10 Jan 2019 22:25:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 520EC29B6B for ; Thu, 10 Jan 2019 22:25:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 469E129B94; Thu, 10 Jan 2019 22:25:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DFE1D29B6B for ; Thu, 10 Jan 2019 22:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728288AbfAJWZN (ORCPT ); Thu, 10 Jan 2019 17:25:13 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:46458 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728800AbfAJWZN (ORCPT ); Thu, 10 Jan 2019 17:25:13 -0500 Received: by mail-pf1-f196.google.com with SMTP id c73so5932653pfe.13 for ; Thu, 10 Jan 2019 14:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cGJpAd8GqozJxbETvXV0rZRryFlooCje2snJMs+3SP8=; b=p2w8UXlgQ61JuYEAJa+T7HTEEWirM9UoXgBrjFClFOKMkfi89M83JEw8uS+tZbU+kY YRF3VqRhz/MjVL+lkuVAmnZThxuIA0lX9qCCmUoycVvzgfAGVaDENjtLPX/vDmk3hUGH PQwxS+UTCT0UUbRIg3P96/KtbEzE63b6T9jGWIi8KAwCQpWw6Ss5eWANi+yh4zq8KVDO TxMKuOuDCTOyB/KbtyPrcj105QskQctwgK3ZqvnN8yNr3j1vThGrHE0GJ62Tbe89MHSC hjRfosp6o2PgO2gf+QRukKw+mvrMI+2c2/DQOIaSdwHP9EtARC00OpX6x24+A3oFYIFP DfYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cGJpAd8GqozJxbETvXV0rZRryFlooCje2snJMs+3SP8=; b=gtynk1Oy6maIDTSiDMKCHMwq+aK2c01zjvtYMhZAzwH9Qow57XluxcUhRjQ2nbJI00 rYh87+fi4gaarDnjS82KdYRm0rk5jp2tFe6R4mQ9lZ/AwnLkxqwZr9wFXqEyw+VTNNQ8 acvhNPk58wwDaLh3HolWFCuUY0/L0GHouLMSrU0h5oq3UnKlw6e+WnLHBL/IGBFyl9VG OI0zqIX+x47JxhydUl11sNMVtIX4QgyKRNBKF2EPsah1tf0l0rtKSTcR/Fck0B39vH/r 1k2DtX2mugPOeJxcwpxu/vQGXWnCWVIDmPru54TNy9/WgkBvZ4PmLJ6lrOfvOL3PlfIr xuSQ== X-Gm-Message-State: AJcUukdLr1HmDD5iBG26p2AOH+yz/kHQnWxElLlmeh8Boy1H2HuACyTG Zhu9ZjN2PVZ7+xj4B25rv+3J4kM= X-Google-Smtp-Source: ALg8bN7p2UcOqFARTfm/bmBtniGCTo49zqezOjj05E5+xnziHen81MYglWd3bHbuG2PzdzSa9CvHVQ== X-Received: by 2002:a63:9501:: with SMTP id p1mr11077882pgd.149.1547159112301; Thu, 10 Jan 2019 14:25:12 -0800 (PST) Received: from ubuntu-vm.corp.microsoft.com ([2001:4898:80e8:3:a18b:4e9f:6b7c:507d]) by smtp.gmail.com with ESMTPSA id z127sm118006755pfb.80.2019.01.10.14.25.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Jan 2019 14:25:11 -0800 (PST) From: Pavel Shilovsky X-Google-Original-From: Pavel Shilovsky To: linux-cifs@vger.kernel.org Cc: Steve French , Ronnie Sahlberg Subject: [PATCH 4/7] CIFS: Do not hide EINTR after sending network packets Date: Thu, 10 Jan 2019 14:24:55 -0800 Message-Id: <1547159098-19011-5-git-send-email-pshilov@microsoft.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1547159098-19011-1-git-send-email-pshilov@microsoft.com> References: <1547159098-19011-1-git-send-email-pshilov@microsoft.com> Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently we hide EINTR code returned from sock_sendmsg() and return 0 instead. This makes a caller think that we have successfully completed the network operation which is not true. Fix this by properly returning EINTR to callers. Cc: Signed-off-by: Pavel Shilovsky --- fs/cifs/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index e047f06..aaff9c5 100644 --- a/fs/cifs/transport.c +++ b/fs/cifs/transport.c @@ -387,7 +387,7 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst, if (rc < 0 && rc != -EINTR) cifs_dbg(VFS, "Error %d sending data on socket to server\n", rc); - else + else if (rc > 0) rc = 0; return rc;