diff mbox series

trace-cmd: Fix make clean error

Message ID 20181203091936.2881-1-kaslevs@vmware.com (mailing list archive)
State Accepted
Commit 4260601dd187f87d450eed437af198f4d39a53bb
Headers show
Series trace-cmd: Fix make clean error | expand

Commit Message

Slavomir Kaslev Dec. 3, 2018, 9:19 a.m. UTC
Fix make clean failing when cmake hasn't generated Makefile for KernelShark:

    $ make clean
    # ...
    make -C /home/kaslevs/src/trace-cmd/kernel-shark-qt/build clean
    make[1]: *** No rule to make target 'clean'.  Stop.
    make: *** [Makefile:365: clean] Error 2

Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Steven Rostedt Dec. 4, 2018, 5:56 a.m. UTC | #1
On Mon,  3 Dec 2018 11:19:36 +0200
Slavomir Kaslev <kaslevs@vmware.com> wrote:

> Fix make clean failing when cmake hasn't generated Makefile for KernelShark:
> 
>     $ make clean
>     # ...
>     make -C /home/kaslevs/src/trace-cmd/kernel-shark-qt/build clean
>     make[1]: *** No rule to make target 'clean'.  Stop.
>     make: *** [Makefile:365: clean] Error 2
> 
> Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>

Applied. Thanks Slavomir!

-- Steve
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 7ee9e0d..562afd1 100644
--- a/Makefile
+++ b/Makefile
@@ -361,11 +361,11 @@  clean:
 	$(RM) tags TAGS cscope*
 	$(MAKE) -C $(src)/lib/traceevent clean
 	$(MAKE) -C $(src)/lib/trace-cmd clean
-	$(MAKE) -C $(src)/kernel-shark clean
-	$(MAKE) -C $(kshark-dir)/build clean
 	$(MAKE) -C $(src)/plugins clean
 	$(MAKE) -C $(src)/python clean
 	$(MAKE) -C $(src)/tracecmd clean
+	$(MAKE) -C $(src)/kernel-shark clean
+	if [ -f $(kshark-dir)/build/Makefile ]; then $(MAKE) -C $(kshark-dir)/build clean; fi
 
 
 ##### PYTHON STUFF #####