| Message ID | 20190112011514.8527-1-shawnguo@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 00ccd4532c8a61e6c65ca62eb7b6da6a272c30f1 |
| Headers | show |
| Series | ARM: dts: vf610-bk4: fix incorrect #address-cells for dspi3 | expand |
Hi Shawn, > The dspi3 is used as slave controller on vf610-bk4, and the default > '#address-cells = <1>;' setting in vfxxx.dtsi causes the following DTC > warning. > > DTC arch/arm/boot/dts/vf610-bk4.dtb > ../arch/arm/boot/dts/vfxxx.dtsi:550.24-563.6: Warning > (spi_bus_bridge): /soc/aips-bus@40080000/spi@400ad000: incorrect > #address-cells for SPI bus also defined > at ../arch/arm/boot/dts/vf610-bk4.dts:107.8-119.3 > arch/arm/boot/dts/vf610-bk4.dtb: Warning (spi_bus_reg): Failed > prerequisite 'spi_bus_bridge' > > For spi device used as slave controller, '#address-cells' should be 0. > Let's overwrite the property in vf610-bk4.dts to fix the warning. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Shawn Guo <shawnguo@kernel.org> > --- > arch/arm/boot/dts/vf610-bk4.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/vf610-bk4.dts > b/arch/arm/boot/dts/vf610-bk4.dts index 689c8930dce3..b08d561d6748 > 100644 --- a/arch/arm/boot/dts/vf610-bk4.dts > +++ b/arch/arm/boot/dts/vf610-bk4.dts > @@ -110,11 +110,11 @@ > bus-num = <3>; > status = "okay"; > spi-slave; > + #address-cells = <0>; > > - slave@0 { > + slave { > compatible = "lwn,bk4"; > spi-max-frequency = <30000000>; > - reg = <0>; > }; > }; > Thanks for fixing this problem, Reviewed-by: Lukasz Majewski <lukma@denx.de> Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/arch/arm/boot/dts/vf610-bk4.dts b/arch/arm/boot/dts/vf610-bk4.dts index 689c8930dce3..b08d561d6748 100644 --- a/arch/arm/boot/dts/vf610-bk4.dts +++ b/arch/arm/boot/dts/vf610-bk4.dts @@ -110,11 +110,11 @@ bus-num = <3>; status = "okay"; spi-slave; + #address-cells = <0>; - slave@0 { + slave { compatible = "lwn,bk4"; spi-max-frequency = <30000000>; - reg = <0>; }; };
The dspi3 is used as slave controller on vf610-bk4, and the default '#address-cells = <1>;' setting in vfxxx.dtsi causes the following DTC warning. DTC arch/arm/boot/dts/vf610-bk4.dtb ../arch/arm/boot/dts/vfxxx.dtsi:550.24-563.6: Warning (spi_bus_bridge): /soc/aips-bus@40080000/spi@400ad000: incorrect #address-cells for SPI bus also defined at ../arch/arm/boot/dts/vf610-bk4.dts:107.8-119.3 arch/arm/boot/dts/vf610-bk4.dtb: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge' For spi device used as slave controller, '#address-cells' should be 0. Let's overwrite the property in vf610-bk4.dts to fix the warning. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Shawn Guo <shawnguo@kernel.org> --- arch/arm/boot/dts/vf610-bk4.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)