[ndctl,v2,3/4] ndctl, monitor: switch to ndctl_cmd_submit_xlat
diff mbox series

Message ID 20190112013035.32087-4-vishal.l.verma@intel.com
State Superseded
Headers show
Series
  • Add missing firmware_status checks
Related show

Commit Message

Verma, Vishal L Jan. 12, 2019, 1:30 a.m. UTC
The ndctl monitor command was neglecting to check the 'firmware_status'
field that is set by the platform firmware to indicate failure. Use
the new ndctl_cmd_submit_xlat facility to include the firmware_status
check as part of the command submission.

Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 ndctl/monitor.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Dan Williams Jan. 12, 2019, 1:54 a.m. UTC | #1
On Fri, Jan 11, 2019 at 5:31 PM Vishal Verma <vishal.l.verma@intel.com> wrote:
>
> The ndctl monitor command was neglecting to check the 'firmware_status'
> field that is set by the platform firmware to indicate failure. Use
> the new ndctl_cmd_submit_xlat facility to include the firmware_status
> check as part of the command submission.
>
> Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

Looks good,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

Patch
diff mbox series

diff --git a/ndctl/monitor.c b/ndctl/monitor.c
index 233f2bb..4ad1429 100644
--- a/ndctl/monitor.c
+++ b/ndctl/monitor.c
@@ -226,7 +226,7 @@  static int enable_dimm_supported_threshold_alarms(struct ndctl_dimm *dimm)
 		err(&monitor, "%s: no smart threshold command support\n", name);
 		goto out;
 	}
-	if (ndctl_cmd_submit(st_cmd)) {
+	if (ndctl_cmd_submit_xlat(st_cmd) < 0) {
 		err(&monitor, "%s: smart threshold command failed\n", name);
 		goto out;
 	}
@@ -246,8 +246,8 @@  static int enable_dimm_supported_threshold_alarms(struct ndctl_dimm *dimm)
 		alarm |= ND_SMART_CTEMP_TRIP;
 	ndctl_cmd_smart_threshold_set_alarm_control(sst_cmd, alarm);
 
-	rc = ndctl_cmd_submit(sst_cmd);
-	if (rc) {
+	rc = ndctl_cmd_submit_xlat(sst_cmd);
+	if (rc < 0) {
 		err(&monitor, "%s: smart set threshold command failed\n", name);
 		goto out;
 	}