scsi: csiostor: fix NULL pointer dereference in csio_vport_set_state()
diff mbox series

Message ID 1547311470-3445-1-git-send-email-varun@chelsio.com
State Mainlined
Commit fe35a40e675473eb65f2f5462b82770f324b5689
Headers show
Series
  • scsi: csiostor: fix NULL pointer dereference in csio_vport_set_state()
Related show

Commit Message

Varun Prakash Jan. 12, 2019, 4:44 p.m. UTC
Assign fc_vport to ln->fc_vport before calling
csio_fcoe_alloc_vnp() to avoid a NULL pointer
dereference in csio_vport_set_state().

ln->fc_vport is dereferenced in csio_vport_set_state().

Signed-off-by: Varun Prakash <varun@chelsio.com>
---
 drivers/scsi/csiostor/csio_attr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Jan. 23, 2019, 1:44 a.m. UTC | #1
Varun,

> Assign fc_vport to ln->fc_vport before calling csio_fcoe_alloc_vnp()
> to avoid a NULL pointer dereference in csio_vport_set_state().
>
> ln->fc_vport is dereferenced in csio_vport_set_state().

Applied to 5.0/scsi-fixes. Thank you!

Patch
diff mbox series

diff --git a/drivers/scsi/csiostor/csio_attr.c b/drivers/scsi/csiostor/csio_attr.c
index 8a00403..9bd2bd8 100644
--- a/drivers/scsi/csiostor/csio_attr.c
+++ b/drivers/scsi/csiostor/csio_attr.c
@@ -594,12 +594,12 @@  csio_vport_create(struct fc_vport *fc_vport, bool disable)
 	}
 
 	fc_vport_set_state(fc_vport, FC_VPORT_INITIALIZING);
+	ln->fc_vport = fc_vport;
 
 	if (csio_fcoe_alloc_vnp(hw, ln))
 		goto error;
 
 	*(struct csio_lnode **)fc_vport->dd_data = ln;
-	ln->fc_vport = fc_vport;
 	if (!fc_vport->node_name)
 		fc_vport->node_name = wwn_to_u64(csio_ln_wwnn(ln));
 	if (!fc_vport->port_name)