| Message ID | 20190116014807.11195-1-richardw.yang@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | acpi/nfit: not set nfit_mem when it is found | expand |
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 9c3c2d2f37be..4643aa10ed2a 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -1053,9 +1053,7 @@ static int __nfit_mem_init(struct acpi_nfit_desc *acpi_desc, break; } - if (found) - nfit_mem = found; - else { + if (!found) { nfit_mem = devm_kzalloc(acpi_desc->dev, sizeof(*nfit_mem), GFP_KERNEL); if (!nfit_mem)
In __nfit_mem_init(), one nfit_mem will be created in case we can't find one nfit_mem with matched device_handle. The variable *found* indicates this research result. If we found one, variable *found* is set to non-NULL and variable *nfit_mem* already points to the data structure we want to set up. This is not necessary to reset variable *nfit_mem* to *found* again. This patch removes the assignment of *nfit_mem* to *found* when they are the same. Signed-off-by: Wei Yang <richardw.yang@linux.intel.com> --- drivers/acpi/nfit/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)