diff mbox series

[02/11] dt-bindings: arm: renesas: Add si-linux cat87[45] boards

Message ID 1547663874-29411-3-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive)
State Accepted
Commit 1a69a73c9b006ae72e06a5e637932bfe2fb7bc05
Delegated to: Geert Uytterhoeven
Headers show
Series Add basic EK874 support | expand

Commit Message

Fabrizio Castro Jan. 16, 2019, 6:37 p.m. UTC 
This patch adds board cat874 (powered by the RZ/G2E) and board
cat875 (that sits on top of cat874). Both boards are made by
Silicon Linux.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
 Documentation/devicetree/bindings/arm/renesas.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Simon Horman Jan. 17, 2019, 10:51 a.m. UTC | #1 
On Wed, Jan 16, 2019 at 06:37:45PM +0000, Fabrizio Castro wrote:
> This patch adds board cat874 (powered by the RZ/G2E) and board
> cat875 (that sits on top of cat874). Both boards are made by
> Silicon Linux.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> ---
>  Documentation/devicetree/bindings/arm/renesas.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
> index 5e9d486..9e1e07b 100644
> --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> @@ -108,6 +108,14 @@ properties:
>  
>        - description: RZ/G2E (R8A774C0)
>          items:
> +          - enum:
> +              - si-linux,cat874 # Silicon Linux RZ/G2E 96board platform (CAT874)

Can I confirm that "96board platform" is correct for this board - I don't
see it in the documentation I have, but that may not mean much.


That aside, I'd like to wait for Rob to indicate if he will accept
patch 1, which adds si-linux as a vendor, before I apply this patch.

> +          - const: renesas,r8a774c0
> +
> +      - items:
> +          - enum:
> +              - si-linux,cat875 # Silicon Linux sub board for CAT874 (CAT875)
> +          - const: si-linux,cat874
>            - const: renesas,r8a774c0
>  
>        - description: R-Car M1A (R8A77781)
> -- 
> 2.7.4
>
Chris Paterson Jan. 17, 2019, 12:32 p.m. UTC | #2 
Hello Simon,

> From: Simon Horman <horms@verge.net.au>
> Sent: 17 January 2019 10:51
> 
> On Wed, Jan 16, 2019 at 06:37:45PM +0000, Fabrizio Castro wrote:
> > This patch adds board cat874 (powered by the RZ/G2E) and board
> > cat875 (that sits on top of cat874). Both boards are made by
> > Silicon Linux.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > ---
> >  Documentation/devicetree/bindings/arm/renesas.yaml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml
> b/Documentation/devicetree/bindings/arm/renesas.yaml
> > index 5e9d486..9e1e07b 100644
> > --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> > @@ -108,6 +108,14 @@ properties:
> >
> >        - description: RZ/G2E (R8A774C0)
> >          items:
> > +          - enum:
> > +              - si-linux,cat874 # Silicon Linux RZ/G2E 96board platform (CAT874)
> 
> Can I confirm that "96board platform" is correct for this board - I don't
> see it in the documentation I have, but that may not mean much.

The board follows the extended version of the Linaro 96board consumer edition (CE) specification [1].

You can see a pretty picture of the board on the CIP Blog [2].

[1] https://www.96boards.org/specifications/
[2] https://www.cip-project.org/blog/2018/10/23/renesas-rz-g2m-96ce-board-adopted-as-arm64-reference-board-for-the-next-cip-slts-kernel

Kind regards, Chris

> 
> 
> That aside, I'd like to wait for Rob to indicate if he will accept
> patch 1, which adds si-linux as a vendor, before I apply this patch.
> 
> > +          - const: renesas,r8a774c0
> > +
> > +      - items:
> > +          - enum:
> > +              - si-linux,cat875 # Silicon Linux sub board for CAT874 (CAT875)
> > +          - const: si-linux,cat874
> >            - const: renesas,r8a774c0
> >
> >        - description: R-Car M1A (R8A77781)
> > --
> > 2.7.4
> >
Simon Horman Jan. 17, 2019, 12:59 p.m. UTC | #3 
On Thu, Jan 17, 2019 at 12:32:37PM +0000, Chris Paterson wrote:
> Hello Simon,
> 
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 17 January 2019 10:51
> > 
> > On Wed, Jan 16, 2019 at 06:37:45PM +0000, Fabrizio Castro wrote:
> > > This patch adds board cat874 (powered by the RZ/G2E) and board
> > > cat875 (that sits on top of cat874). Both boards are made by
> > > Silicon Linux.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > ---
> > >  Documentation/devicetree/bindings/arm/renesas.yaml | 8 ++++++++
> > >  1 file changed, 8 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml
> > b/Documentation/devicetree/bindings/arm/renesas.yaml
> > > index 5e9d486..9e1e07b 100644
> > > --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> > > @@ -108,6 +108,14 @@ properties:
> > >
> > >        - description: RZ/G2E (R8A774C0)
> > >          items:
> > > +          - enum:
> > > +              - si-linux,cat874 # Silicon Linux RZ/G2E 96board platform (CAT874)
> > 
> > Can I confirm that "96board platform" is correct for this board - I don't
> > see it in the documentation I have, but that may not mean much.
> 
> The board follows the extended version of the Linaro 96board consumer edition (CE) specification [1].
> 
> You can see a pretty picture of the board on the CIP Blog [2].
> 
> [1] https://www.96boards.org/specifications/
> [2] https://www.cip-project.org/blog/2018/10/23/renesas-rz-g2m-96ce-board-adopted-as-arm64-reference-board-for-the-next-cip-slts-kernel

Thanks Chris, in that case I am fine with this patch.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> > That aside, I'd like to wait for Rob to indicate if he will accept
> > patch 1, which adds si-linux as a vendor, before I apply this patch.
> > 
> > > +          - const: renesas,r8a774c0
> > > +
> > > +      - items:
> > > +          - enum:
> > > +              - si-linux,cat875 # Silicon Linux sub board for CAT874 (CAT875)
> > > +          - const: si-linux,cat874
> > >            - const: renesas,r8a774c0
> > >
> > >        - description: R-Car M1A (R8A77781)
> > > --
> > > 2.7.4
> > >
>
Simon Horman Jan. 22, 2019, 2:49 p.m. UTC | #4 
On Thu, Jan 17, 2019 at 01:59:12PM +0100, Simon Horman wrote:
> On Thu, Jan 17, 2019 at 12:32:37PM +0000, Chris Paterson wrote:
> > Hello Simon,
> > 
> > > From: Simon Horman <horms@verge.net.au>
> > > Sent: 17 January 2019 10:51
> > > 
> > > On Wed, Jan 16, 2019 at 06:37:45PM +0000, Fabrizio Castro wrote:
> > > > This patch adds board cat874 (powered by the RZ/G2E) and board
> > > > cat875 (that sits on top of cat874). Both boards are made by
> > > > Silicon Linux.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/arm/renesas.yaml | 8 ++++++++
> > > >  1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml
> > > b/Documentation/devicetree/bindings/arm/renesas.yaml
> > > > index 5e9d486..9e1e07b 100644
> > > > --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> > > > @@ -108,6 +108,14 @@ properties:
> > > >
> > > >        - description: RZ/G2E (R8A774C0)
> > > >          items:
> > > > +          - enum:
> > > > +              - si-linux,cat874 # Silicon Linux RZ/G2E 96board platform (CAT874)
> > > 
> > > Can I confirm that "96board platform" is correct for this board - I don't
> > > see it in the documentation I have, but that may not mean much.
> > 
> > The board follows the extended version of the Linaro 96board consumer edition (CE) specification [1].
> > 
> > You can see a pretty picture of the board on the CIP Blog [2].
> > 
> > [1] https://www.96boards.org/specifications/
> > [2] https://www.cip-project.org/blog/2018/10/23/renesas-rz-g2m-96ce-board-adopted-as-arm64-reference-board-for-the-next-cip-slts-kernel
> 
> Thanks Chris, in that case I am fine with this patch.
> 
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> 
> > > That aside, I'd like to wait for Rob to indicate if he will accept
> > > patch 1, which adds si-linux as a vendor, before I apply this patch.

It appears that the use of si-linux as a vendor name.
Accordingly I have applied this patch for v5.1.

...
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
index 5e9d486..9e1e07b 100644
--- a/Documentation/devicetree/bindings/arm/renesas.yaml
+++ b/Documentation/devicetree/bindings/arm/renesas.yaml
@@ -108,6 +108,14 @@  properties:
 
       - description: RZ/G2E (R8A774C0)
         items:
+          - enum:
+              - si-linux,cat874 # Silicon Linux RZ/G2E 96board platform (CAT874)
+          - const: renesas,r8a774c0
+
+      - items:
+          - enum:
+              - si-linux,cat875 # Silicon Linux sub board for CAT874 (CAT875)
+          - const: si-linux,cat874
           - const: renesas,r8a774c0
 
       - description: R-Car M1A (R8A77781)