[5/5] ASoC: imx-sgtl5000: lower log level for potential probe deferral cases
diff mbox series

Message ID 20190117090640.12972-5-stefan@agner.ch
State New
Headers show
Series
  • [1/5] ASoC: fsl_spdif: don't print EPROBE_DEFER as error
Related show

Commit Message

Stefan Agner Jan. 17, 2019, 9:06 a.m. UTC
Not finding the codec/SSI instance can be due to probe deferral.
Do not print error messages in those cases.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 sound/soc/fsl/imx-sgtl5000.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Daniel Baluta Jan. 17, 2019, 10 a.m. UTC | #1
On Thu, Jan 17, 2019 at 11:07 AM Stefan Agner <stefan@agner.ch> wrote:
>
> Not finding the codec/SSI instance can be due to probe deferral.
> Do not print error messages in those cases.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Nicolin Chen Jan. 17, 2019, 10:01 p.m. UTC | #2
On Thu, Jan 17, 2019 at 10:06:40AM +0100, Stefan Agner wrote:
> Not finding the codec/SSI instance can be due to probe deferral.
> Do not print error messages in those cases.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

> ---
>  sound/soc/fsl/imx-sgtl5000.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
> index 45969e6dfad7..b6cb80480b60 100644
> --- a/sound/soc/fsl/imx-sgtl5000.c
> +++ b/sound/soc/fsl/imx-sgtl5000.c
> @@ -104,13 +104,13 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
>  
>  	ssi_pdev = of_find_device_by_node(ssi_np);
>  	if (!ssi_pdev) {
> -		dev_err(&pdev->dev, "failed to find SSI platform device\n");
> +		dev_dbg(&pdev->dev, "failed to find SSI platform device\n");
>  		ret = -EPROBE_DEFER;
>  		goto fail;
>  	}
>  	codec_dev = of_find_i2c_device_by_node(codec_np);
>  	if (!codec_dev) {
> -		dev_err(&pdev->dev, "failed to find codec platform device\n");
> +		dev_dbg(&pdev->dev, "failed to find codec platform device\n");
>  		ret = -EPROBE_DEFER;
>  		goto fail;
>  	}
> -- 
> 2.20.1
>

Patch
diff mbox series

diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
index 45969e6dfad7..b6cb80480b60 100644
--- a/sound/soc/fsl/imx-sgtl5000.c
+++ b/sound/soc/fsl/imx-sgtl5000.c
@@ -104,13 +104,13 @@  static int imx_sgtl5000_probe(struct platform_device *pdev)
 
 	ssi_pdev = of_find_device_by_node(ssi_np);
 	if (!ssi_pdev) {
-		dev_err(&pdev->dev, "failed to find SSI platform device\n");
+		dev_dbg(&pdev->dev, "failed to find SSI platform device\n");
 		ret = -EPROBE_DEFER;
 		goto fail;
 	}
 	codec_dev = of_find_i2c_device_by_node(codec_np);
 	if (!codec_dev) {
-		dev_err(&pdev->dev, "failed to find codec platform device\n");
+		dev_dbg(&pdev->dev, "failed to find codec platform device\n");
 		ret = -EPROBE_DEFER;
 		goto fail;
 	}