cw1200: fix indentation issues
diff mbox series

Message ID 20190117143623.29363-1-colin.king@canonical.com
State Accepted
Commit b0535d502d1804197f3aaaaf5a3429c5779268e4
Delegated to: Kalle Valo
Headers show
Series
  • cw1200: fix indentation issues
Related show

Commit Message

Colin King Jan. 17, 2019, 2:36 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

There are two lines that have indentation issues, fix these.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/st/cw1200/fwio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kalle Valo Jan. 17, 2019, 2:54 p.m. UTC | #1
Colin King <colin.king@canonical.com> writes:

> From: Colin Ian King <colin.king@canonical.com>
>
> There are two lines that have indentation issues, fix these.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/wireless/st/cw1200/fwio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c
> index 30e7646d04af..b7881232499c 100644
> --- a/drivers/net/wireless/st/cw1200/fwio.c
> +++ b/drivers/net/wireless/st/cw1200/fwio.c
> @@ -465,8 +465,8 @@ int cw1200_load_firmware(struct cw1200_common *priv)
>  
>  	if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) {
>  		pr_err("Device is already in QUEUE mode!\n");
> -			ret = -EINVAL;
> -			goto out;
> +		ret = -EINVAL;
> +		goto out;

Just out of curiosity, how do you find these?
Colin King Jan. 17, 2019, 2:56 p.m. UTC | #2
On 17/01/2019 14:54, Kalle Valo wrote:
> Colin King <colin.king@canonical.com> writes:
> 
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There are two lines that have indentation issues, fix these.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>  drivers/net/wireless/st/cw1200/fwio.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c
>> index 30e7646d04af..b7881232499c 100644
>> --- a/drivers/net/wireless/st/cw1200/fwio.c
>> +++ b/drivers/net/wireless/st/cw1200/fwio.c
>> @@ -465,8 +465,8 @@ int cw1200_load_firmware(struct cw1200_common *priv)
>>  
>>  	if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) {
>>  		pr_err("Device is already in QUEUE mode!\n");
>> -			ret = -EINVAL;
>> -			goto out;
>> +		ret = -EINVAL;
>> +		goto out;
> 
> Just out of curiosity, how do you find these?
> 
smatch, grep for "warn: inconsistent indenting"

Colin
Kalle Valo Feb. 1, 2019, 12:19 p.m. UTC | #3
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> There are two lines that have indentation issues, fix these.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied to wireless-drivers-next.git, thanks.

b0535d502d18 cw1200: fix indentation issues

Patch
diff mbox series

diff --git a/drivers/net/wireless/st/cw1200/fwio.c b/drivers/net/wireless/st/cw1200/fwio.c
index 30e7646d04af..b7881232499c 100644
--- a/drivers/net/wireless/st/cw1200/fwio.c
+++ b/drivers/net/wireless/st/cw1200/fwio.c
@@ -465,8 +465,8 @@  int cw1200_load_firmware(struct cw1200_common *priv)
 
 	if (!(val32 & ST90TDS_CONFIG_ACCESS_MODE_BIT)) {
 		pr_err("Device is already in QUEUE mode!\n");
-			ret = -EINVAL;
-			goto out;
+		ret = -EINVAL;
+		goto out;
 	}
 
 	switch (priv->hw_type)  {