diff mbox series

btrfs: simplify workqueue name when allocating

Message ID 20190117161518.24199-1-dsterba@suse.com (mailing list archive)
State New, archived
Headers show
Series btrfs: simplify workqueue name when allocating | expand

Commit Message

David Sterba Jan. 17, 2019, 4:15 p.m. UTC
The workqueue name is constructed from a format string but the prefix
does not need to be set by %s.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/async-thread.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Comments

Nikolay Borisov Jan. 17, 2019, 4:17 p.m. UTC | #1
On 17.01.19 г. 18:15 ч., David Sterba wrote:
> The workqueue name is constructed from a format string but the prefix
> does not need to be set by %s.
> 
> Signed-off-by: David Sterba <dsterba@suse.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
>  fs/btrfs/async-thread.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
> index 44a7942f0457..92dfc70f9511 100644
> --- a/fs/btrfs/async-thread.c
> +++ b/fs/btrfs/async-thread.c
> @@ -127,13 +127,11 @@ __btrfs_alloc_workqueue(struct btrfs_fs_info *fs_info, const char *name,
>  	}
>  
>  	if (flags & WQ_HIGHPRI)
> -		ret->normal_wq = alloc_workqueue("%s-%s-high", flags,
> -						 ret->current_active, "btrfs",
> -						 name);
> +		ret->normal_wq = alloc_workqueue("btrfs-%s-high", flags,
> +						 ret->current_active, name);
>  	else
> -		ret->normal_wq = alloc_workqueue("%s-%s", flags,
> -						 ret->current_active, "btrfs",
> -						 name);
> +		ret->normal_wq = alloc_workqueue("btrfs-%s", flags,
> +						 ret->current_active, name);
>  	if (!ret->normal_wq) {
>  		kfree(ret);
>  		return NULL;
>
diff mbox series

Patch

diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
index 44a7942f0457..92dfc70f9511 100644
--- a/fs/btrfs/async-thread.c
+++ b/fs/btrfs/async-thread.c
@@ -127,13 +127,11 @@  __btrfs_alloc_workqueue(struct btrfs_fs_info *fs_info, const char *name,
 	}
 
 	if (flags & WQ_HIGHPRI)
-		ret->normal_wq = alloc_workqueue("%s-%s-high", flags,
-						 ret->current_active, "btrfs",
-						 name);
+		ret->normal_wq = alloc_workqueue("btrfs-%s-high", flags,
+						 ret->current_active, name);
 	else
-		ret->normal_wq = alloc_workqueue("%s-%s", flags,
-						 ret->current_active, "btrfs",
-						 name);
+		ret->normal_wq = alloc_workqueue("btrfs-%s", flags,
+						 ret->current_active, name);
 	if (!ret->normal_wq) {
 		kfree(ret);
 		return NULL;