| Message ID | 20190117231500.970473486@linutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | None | expand |
pi 18. 1. 2019 o 0:15 Thomas Gleixner <tglx@linutronix.de> napísal(a): > Precise and non-ambiguous license information is important. The recently > added aegis header file has a SPDX license identifier, which is nice, but > at the same time it has a contradictionary license boiler plate text. > > SPDX-License-Identifier: GPL-2.0 > > versus > > * This program is free software; you can redistribute it and/or modify it > * under the terms of the GNU General Public License as published by the Free > * Software Foundation; either version 2 of the License, or (at your option) > * any later version > > Oh well. > > As the other aegis related files are licensed under the GPL v2 or later, > it's assumed that the boiler plate code is correct, but the SPDX license > identifier is wrong. > > Fix the SPDX identifier and remove the boiler plate as it is redundant. > > Fixes: f606a88e5823 ("crypto: aegis - Add generic AEGIS AEAD implementations") > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Ondrej Mosnacek <omosnacek@gmail.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-crypto@vger.kernel.org Acked-by: Ondrej Mosnacek <omosnacek@gmail.com> (feel free to keep the ack also if you decide to switch to the "GPL-2.0+" form) > --- > > P.S.: This patch is part of a larger cleanup, but independent of other > patches and is intended to be picked up by the maintainer directly. > > --- > crypto/aegis.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > --- a/crypto/aegis.h > +++ b/crypto/aegis.h > @@ -1,14 +1,9 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > /* > * AEGIS common definitions > * > * Copyright (c) 2018 Ondrej Mosnacek <omosnacek@gmail.com> > * Copyright (c) 2018 Red Hat, Inc. All rights reserved. > - * > - * This program is free software; you can redistribute it and/or modify it > - * under the terms of the GNU General Public License as published by the Free > - * Software Foundation; either version 2 of the License, or (at your option) > - * any later version. > */ > > #ifndef _CRYPTO_AEGIS_H > >
On Fri, Jan 18, 2019 at 12:14:18AM +0100, Thomas Gleixner wrote: > Precise and non-ambiguous license information is important. The recently > added aegis header file has a SPDX license identifier, which is nice, but > at the same time it has a contradictionary license boiler plate text. > > SPDX-License-Identifier: GPL-2.0 > > versus > > * This program is free software; you can redistribute it and/or modify it > * under the terms of the GNU General Public License as published by the Free > * Software Foundation; either version 2 of the License, or (at your option) > * any later version > > Oh well. > > As the other aegis related files are licensed under the GPL v2 or later, > it's assumed that the boiler plate code is correct, but the SPDX license > identifier is wrong. > > Fix the SPDX identifier and remove the boiler plate as it is redundant. > > Fixes: f606a88e5823 ("crypto: aegis - Add generic AEGIS AEAD implementations") > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Ondrej Mosnacek <omosnacek@gmail.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: linux-crypto@vger.kernel.org > --- > > P.S.: This patch is part of a larger cleanup, but independent of other > patches and is intended to be picked up by the maintainer directly. > > --- > crypto/aegis.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Patches 2-5 applied. Thanks.
--- a/crypto/aegis.h +++ b/crypto/aegis.h @@ -1,14 +1,9 @@ -/* SPDX-License-Identifier: GPL-2.0 */ +/* SPDX-License-Identifier: GPL-2.0-or-later */ /* * AEGIS common definitions * * Copyright (c) 2018 Ondrej Mosnacek <omosnacek@gmail.com> * Copyright (c) 2018 Red Hat, Inc. All rights reserved. - * - * This program is free software; you can redistribute it and/or modify it - * under the terms of the GNU General Public License as published by the Free - * Software Foundation; either version 2 of the License, or (at your option) - * any later version. */ #ifndef _CRYPTO_AEGIS_H
Precise and non-ambiguous license information is important. The recently added aegis header file has a SPDX license identifier, which is nice, but at the same time it has a contradictionary license boiler plate text. SPDX-License-Identifier: GPL-2.0 versus * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by the Free * Software Foundation; either version 2 of the License, or (at your option) * any later version Oh well. As the other aegis related files are licensed under the GPL v2 or later, it's assumed that the boiler plate code is correct, but the SPDX license identifier is wrong. Fix the SPDX identifier and remove the boiler plate as it is redundant. Fixes: f606a88e5823 ("crypto: aegis - Add generic AEGIS AEAD implementations") Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Ondrej Mosnacek <omosnacek@gmail.com> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: "David S. Miller" <davem@davemloft.net> Cc: linux-crypto@vger.kernel.org --- P.S.: This patch is part of a larger cleanup, but independent of other patches and is intended to be picked up by the maintainer directly. --- crypto/aegis.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)