diff mbox series

[blktests,v3,04/13] block: Whitelist tests supporting zoned block devices

Message ID 20190118094453.13773-5-shinichiro.kawasaki@wdc.com (mailing list archive)
State New, archived
Headers show
Series Implement zoned block device support | expand

Commit Message

Shinichiro Kawasaki Jan. 18, 2019, 9:44 a.m. UTC 
Define CAN_BE_ZONED=1 in block/005, block/006, block/010, block/011,
block/016, block/017, block/020, block/021 and block/023 as all these
tests should execute without any problem against null_blk with zoned
mode enabled or zoned block devices specified in TEST_DEVS.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 tests/block/005 | 1 +
 tests/block/006 | 1 +
 tests/block/010 | 1 +
 tests/block/011 | 1 +
 tests/block/016 | 1 +
 tests/block/017 | 1 +
 tests/block/020 | 1 +
 tests/block/021 | 1 +
 tests/block/023 | 1 +
 9 files changed, 9 insertions(+)

Comments

Omar Sandoval Jan. 25, 2019, 9:11 p.m. UTC | #1 
On Fri, Jan 18, 2019 at 06:44:44PM +0900, Shin'ichiro Kawasaki wrote:
> Define CAN_BE_ZONED=1 in block/005, block/006, block/010, block/011,
> block/016, block/017, block/020, block/021 and block/023 as all these
> tests should execute without any problem against null_blk with zoned
> mode enabled or zoned block devices specified in TEST_DEVS.

Several of these tests do random I/O, did I miss a change that makes fio
use zonemode=zbd or something?

> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> ---
>  tests/block/005 | 1 +
>  tests/block/006 | 1 +
>  tests/block/010 | 1 +
>  tests/block/011 | 1 +
>  tests/block/016 | 1 +
>  tests/block/017 | 1 +
>  tests/block/020 | 1 +
>  tests/block/021 | 1 +
>  tests/block/023 | 1 +
>  9 files changed, 9 insertions(+)
> 
> diff --git a/tests/block/005 b/tests/block/005
> index 65eba22..8ab6791 100755
> --- a/tests/block/005
> +++ b/tests/block/005
> @@ -8,6 +8,7 @@
>  
>  DESCRIPTION="switch schedulers while doing IO"
>  TIMED=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_fio
> diff --git a/tests/block/006 b/tests/block/006
> index 630d478..0b8a3c0 100755
> --- a/tests/block/006
> +++ b/tests/block/006
> @@ -12,6 +12,7 @@
>  
>  DESCRIPTION="run null-blk in blocking mode"
>  TIMED=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk && _have_module_param null_blk blocking && _have_fio
> diff --git a/tests/block/010 b/tests/block/010
> index 76b301f..b81208e 100644
> --- a/tests/block/010
> +++ b/tests/block/010
> @@ -12,6 +12,7 @@
>  
>  DESCRIPTION="run I/O on null_blk with shared and non-shared tags"
>  TIMED=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk && _have_module_param null_blk shared_tags && _have_fio
> diff --git a/tests/block/011 b/tests/block/011
> index 8e10900..c3432a6 100755
> --- a/tests/block/011
> +++ b/tests/block/011
> @@ -8,6 +8,7 @@
>  
>  DESCRIPTION="disable PCI device while doing I/O"
>  TIMED=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_fio && _have_program setpci
> diff --git a/tests/block/016 b/tests/block/016
> index 10ec4ba..c70b7d0 100755
> --- a/tests/block/016
> +++ b/tests/block/016
> @@ -11,6 +11,7 @@
>  
>  DESCRIPTION="send a signal to a process waiting on a frozen queue"
>  QUICK=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk
> diff --git a/tests/block/017 b/tests/block/017
> index cea29be..e4a9259 100755
> --- a/tests/block/017
> +++ b/tests/block/017
> @@ -11,6 +11,7 @@
>  
>  DESCRIPTION="do I/O and check the inflight counter"
>  QUICK=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk
> diff --git a/tests/block/020 b/tests/block/020
> index a377ea2..39dde66 100755
> --- a/tests/block/020
> +++ b/tests/block/020
> @@ -11,6 +11,7 @@
>  
>  DESCRIPTION="run null-blk on different schedulers with only one hardware tag"
>  QUICK=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk && _have_fio
> diff --git a/tests/block/021 b/tests/block/021
> index 0ca5a17..a1bbf45 100755
> --- a/tests/block/021
> +++ b/tests/block/021
> @@ -11,6 +11,7 @@
>  
>  DESCRIPTION="read/write nr_requests on null-blk with different schedulers"
>  QUICK=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk
> diff --git a/tests/block/023 b/tests/block/023
> index b0739f7..0f20f4a 100755
> --- a/tests/block/023
> +++ b/tests/block/023
> @@ -10,6 +10,7 @@
>  
>  DESCRIPTION="do I/O on all null_blk queue modes"
>  QUICK=1
> +CAN_BE_ZONED=1
>  
>  requires() {
>  	_have_null_blk
> -- 
> 2.20.1
>
Shinichiro Kawasaki Jan. 28, 2019, 10:37 a.m. UTC | #2 
On 1/26/19 6:11 AM, Omar Sandoval wrote:
> On Fri, Jan 18, 2019 at 06:44:44PM +0900, Shin'ichiro Kawasaki wrote:
>> Define CAN_BE_ZONED=1 in block/005, block/006, block/010, block/011,
>> block/016, block/017, block/020, block/021 and block/023 as all these
>> tests should execute without any problem against null_blk with zoned
>> mode enabled or zoned block devices specified in TEST_DEVS.
> 
> Several of these tests do random I/O, did I miss a change that makes fio
> use zonemode=zbd or something?

Five of the test cases white listed call fio with random "read" I/O. Random 
"write" I/O requires zonemode=zbd, but "read" I/O doesn't. block/006, block/010 
and block/020 specify --rw=randread option explicitly. block/005 and block/011 
call _run_fio_rand_io() and the function specifies --rw=randread. For these test 
cases, current fio options can be applied to the zoned block devices without 
zonmode=zbd.

>> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>> ---
>>   tests/block/005 | 1 +
>>   tests/block/006 | 1 +
>>   tests/block/010 | 1 +
>>   tests/block/011 | 1 +
>>   tests/block/016 | 1 +
>>   tests/block/017 | 1 +
>>   tests/block/020 | 1 +
>>   tests/block/021 | 1 +
>>   tests/block/023 | 1 +
>>   9 files changed, 9 insertions(+)
>>
>> diff --git a/tests/block/005 b/tests/block/005
>> index 65eba22..8ab6791 100755
>> --- a/tests/block/005
>> +++ b/tests/block/005
>> @@ -8,6 +8,7 @@
>>   
>>   DESCRIPTION="switch schedulers while doing IO"
>>   TIMED=1
>> +CAN_BE_ZONED=1
>>   
>>   requires() {
>>   	_have_fio
>> diff --git a/tests/block/006 b/tests/block/006
>> index 630d478..0b8a3c0 100755
>> --- a/tests/block/006
>> +++ b/tests/block/006
>> @@ -12,6 +12,7 @@
>>   
>>   DESCRIPTION="run null-blk in blocking mode"
>>   TIMED=1
>> +CAN_BE_ZONED=1
>>   
>>   requires() {
>>   	_have_null_blk && _have_module_param null_blk blocking && _have_fio
>> diff --git a/tests/block/010 b/tests/block/010
>> index 76b301f..b81208e 100644
>> --- a/tests/block/010
>> +++ b/tests/block/010
>> @@ -12,6 +12,7 @@
>>   
>>   DESCRIPTION="run I/O on null_blk with shared and non-shared tags"
>>   TIMED=1
>> +CAN_BE_ZONED=1
>>   
>>   requires() {
>>   	_have_null_blk && _have_module_param null_blk shared_tags && _have_fio
>> diff --git a/tests/block/011 b/tests/block/011
>> index 8e10900..c3432a6 100755
>> --- a/tests/block/011
>> +++ b/tests/block/011
>> @@ -8,6 +8,7 @@
>>   
>>   DESCRIPTION="disable PCI device while doing I/O"
>>   TIMED=1
>> +CAN_BE_ZONED=1
>>   
>>   requires() {
>>   	_have_fio && _have_program setpci
>> diff --git a/tests/block/016 b/tests/block/016
>> index 10ec4ba..c70b7d0 100755
>> --- a/tests/block/016
>> +++ b/tests/block/016
>> @@ -11,6 +11,7 @@
>>   
>>   DESCRIPTION="send a signal to a process waiting on a frozen queue"
>>   QUICK=1
>> +CAN_BE_ZONED=1
>>   
>>   requires() {
>>   	_have_null_blk
>> diff --git a/tests/block/017 b/tests/block/017
>> index cea29be..e4a9259 100755
>> --- a/tests/block/017
>> +++ b/tests/block/017
>> @@ -11,6 +11,7 @@
>>   
>>   DESCRIPTION="do I/O and check the inflight counter"
>>   QUICK=1
>> +CAN_BE_ZONED=1
>>   
>>   requires() {
>>   	_have_null_blk
>> diff --git a/tests/block/020 b/tests/block/020
>> index a377ea2..39dde66 100755
>> --- a/tests/block/020
>> +++ b/tests/block/020
>> @@ -11,6 +11,7 @@
>>   
>>   DESCRIPTION="run null-blk on different schedulers with only one hardware tag"
>>   QUICK=1
>> +CAN_BE_ZONED=1
>>   
>>   requires() {
>>   	_have_null_blk && _have_fio
>> diff --git a/tests/block/021 b/tests/block/021
>> index 0ca5a17..a1bbf45 100755
>> --- a/tests/block/021
>> +++ b/tests/block/021
>> @@ -11,6 +11,7 @@
>>   
>>   DESCRIPTION="read/write nr_requests on null-blk with different schedulers"
>>   QUICK=1
>> +CAN_BE_ZONED=1
>>   
>>   requires() {
>>   	_have_null_blk
>> diff --git a/tests/block/023 b/tests/block/023
>> index b0739f7..0f20f4a 100755
>> --- a/tests/block/023
>> +++ b/tests/block/023
>> @@ -10,6 +10,7 @@
>>   
>>   DESCRIPTION="do I/O on all null_blk queue modes"
>>   QUICK=1
>> +CAN_BE_ZONED=1
>>   
>>   requires() {
>>   	_have_null_blk
>> -- 
>> 2.20.1
>>
>
diff mbox series

Patch

diff --git a/tests/block/005 b/tests/block/005
index 65eba22..8ab6791 100755
--- a/tests/block/005
+++ b/tests/block/005
@@ -8,6 +8,7 @@ 
 
 DESCRIPTION="switch schedulers while doing IO"
 TIMED=1
+CAN_BE_ZONED=1
 
 requires() {
 	_have_fio
diff --git a/tests/block/006 b/tests/block/006
index 630d478..0b8a3c0 100755
--- a/tests/block/006
+++ b/tests/block/006
@@ -12,6 +12,7 @@ 
 
 DESCRIPTION="run null-blk in blocking mode"
 TIMED=1
+CAN_BE_ZONED=1
 
 requires() {
 	_have_null_blk && _have_module_param null_blk blocking && _have_fio
diff --git a/tests/block/010 b/tests/block/010
index 76b301f..b81208e 100644
--- a/tests/block/010
+++ b/tests/block/010
@@ -12,6 +12,7 @@ 
 
 DESCRIPTION="run I/O on null_blk with shared and non-shared tags"
 TIMED=1
+CAN_BE_ZONED=1
 
 requires() {
 	_have_null_blk && _have_module_param null_blk shared_tags && _have_fio
diff --git a/tests/block/011 b/tests/block/011
index 8e10900..c3432a6 100755
--- a/tests/block/011
+++ b/tests/block/011
@@ -8,6 +8,7 @@ 
 
 DESCRIPTION="disable PCI device while doing I/O"
 TIMED=1
+CAN_BE_ZONED=1
 
 requires() {
 	_have_fio && _have_program setpci
diff --git a/tests/block/016 b/tests/block/016
index 10ec4ba..c70b7d0 100755
--- a/tests/block/016
+++ b/tests/block/016
@@ -11,6 +11,7 @@ 
 
 DESCRIPTION="send a signal to a process waiting on a frozen queue"
 QUICK=1
+CAN_BE_ZONED=1
 
 requires() {
 	_have_null_blk
diff --git a/tests/block/017 b/tests/block/017
index cea29be..e4a9259 100755
--- a/tests/block/017
+++ b/tests/block/017
@@ -11,6 +11,7 @@ 
 
 DESCRIPTION="do I/O and check the inflight counter"
 QUICK=1
+CAN_BE_ZONED=1
 
 requires() {
 	_have_null_blk
diff --git a/tests/block/020 b/tests/block/020
index a377ea2..39dde66 100755
--- a/tests/block/020
+++ b/tests/block/020
@@ -11,6 +11,7 @@ 
 
 DESCRIPTION="run null-blk on different schedulers with only one hardware tag"
 QUICK=1
+CAN_BE_ZONED=1
 
 requires() {
 	_have_null_blk && _have_fio
diff --git a/tests/block/021 b/tests/block/021
index 0ca5a17..a1bbf45 100755
--- a/tests/block/021
+++ b/tests/block/021
@@ -11,6 +11,7 @@ 
 
 DESCRIPTION="read/write nr_requests on null-blk with different schedulers"
 QUICK=1
+CAN_BE_ZONED=1
 
 requires() {
 	_have_null_blk
diff --git a/tests/block/023 b/tests/block/023
index b0739f7..0f20f4a 100755
--- a/tests/block/023
+++ b/tests/block/023
@@ -10,6 +10,7 @@ 
 
 DESCRIPTION="do I/O on all null_blk queue modes"
 QUICK=1
+CAN_BE_ZONED=1
 
 requires() {
 	_have_null_blk