| Message ID | 20190118164610.8123-3-julien.grall@arm.com (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
| Series | arm64/sve: First steps towards optimizing syscalls | expand |
On Fri, Jan 18, 2019 at 04:46:04PM +0000, Julien Grall wrote: > The SVE state is saved by fpsimd_signal_preserve_current_state() and not > preserve_fpsimd_context(). Update the comment in preserve_sve_context to > reflect the current behavior. > > Signed-off-by: Julien Grall <julien.grall@arm.com> > --- > arch/arm64/kernel/signal.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c > index 867a7cea70e5..11e335f489b0 100644 > --- a/arch/arm64/kernel/signal.c > +++ b/arch/arm64/kernel/signal.c > @@ -255,7 +255,8 @@ static int preserve_sve_context(struct sve_context __user *ctx) > if (vq) { > /* > * This assumes that the SVE state has already been saved to > - * the task struct by calling preserve_fpsimd_context(). > + * the task struct by calling the function > + * fpsimd_signal_preserve_current_state(). This can be: /* * This assumes that the SVE state has already been saved to * the task struct by fpsimd_signal_preserve_current_state(). */ ... which avoids the additional words and weird line split. Otherwise, I think the change is logically correct. Thanks, Mark. > */ > err |= __copy_to_user((char __user *)ctx + SVE_SIG_REGS_OFFSET, > current->thread.sve_state, > -- > 2.11.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c index 867a7cea70e5..11e335f489b0 100644 --- a/arch/arm64/kernel/signal.c +++ b/arch/arm64/kernel/signal.c @@ -255,7 +255,8 @@ static int preserve_sve_context(struct sve_context __user *ctx) if (vq) { /* * This assumes that the SVE state has already been saved to - * the task struct by calling preserve_fpsimd_context(). + * the task struct by calling the function + * fpsimd_signal_preserve_current_state(). */ err |= __copy_to_user((char __user *)ctx + SVE_SIG_REGS_OFFSET, current->thread.sve_state,
The SVE state is saved by fpsimd_signal_preserve_current_state() and not preserve_fpsimd_context(). Update the comment in preserve_sve_context to reflect the current behavior. Signed-off-by: Julien Grall <julien.grall@arm.com> --- arch/arm64/kernel/signal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)