diff mbox series

arch/arm64: Add the various compression methods to the default config

Message ID 20190119185540.20526-1-tobias.johannes.klausmann@mni.thm.de (mailing list archive)
State New, archived
Headers show
Series arch/arm64: Add the various compression methods to the default config | expand

Commit Message

Tobias Klausmann Jan. 19, 2019, 6:55 p.m. UTC
There is no reason having arm64 not select these configurations by
default!

Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
---
 arch/arm64/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Will Deacon Jan. 19, 2019, 9:02 p.m. UTC | #1
On Sat, Jan 19, 2019 at 07:55:40PM +0100, Tobias Klausmann wrote:
> There is no reason having arm64 not select these configurations by
> default!
> 
> Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
> ---
>  arch/arm64/Kconfig | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index a4168d366127..91a5e1cd7279 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -140,6 +140,11 @@ config ARM64
>  	select HAVE_GENERIC_DMA_COHERENT
>  	select HAVE_HW_BREAKPOINT if PERF_EVENTS
>  	select HAVE_IRQ_TIME_ACCOUNTING
> +	select HAVE_KERNEL_GZIP
> +	select HAVE_KERNEL_LZ4
> +	select HAVE_KERNEL_LZMA
> +	select HAVE_KERNEL_LZO
> +	select HAVE_KERNEL_XZ
>  	select HAVE_MEMBLOCK_NODE_MAP if NUMA
>  	select HAVE_NMI
>  	select HAVE_PATA_PLATFORM

I don't really understand what this patch achieves. We don't have a built-in
decompressor for arm64, as we defer to the bootloader to handle that for us
instead. The Image.gz target already produces a gzipped kernel payload.

What are you trying to do?

Will
Tobias Klausmann Jan. 21, 2019, 12:38 a.m. UTC | #2
On 19.01.19 22:02, Will Deacon wrote:
> On Sat, Jan 19, 2019 at 07:55:40PM +0100, Tobias Klausmann wrote:
>> There is no reason having arm64 not select these configurations by
>> default!
>>
>> Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
>> ---
>>   arch/arm64/Kconfig | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index a4168d366127..91a5e1cd7279 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -140,6 +140,11 @@ config ARM64
>>   	select HAVE_GENERIC_DMA_COHERENT
>>   	select HAVE_HW_BREAKPOINT if PERF_EVENTS
>>   	select HAVE_IRQ_TIME_ACCOUNTING
>> +	select HAVE_KERNEL_GZIP
>> +	select HAVE_KERNEL_LZ4
>> +	select HAVE_KERNEL_LZMA
>> +	select HAVE_KERNEL_LZO
>> +	select HAVE_KERNEL_XZ
>>   	select HAVE_MEMBLOCK_NODE_MAP if NUMA
>>   	select HAVE_NMI
>>   	select HAVE_PATA_PLATFORM
> I don't really understand what this patch achieves. We don't have a built-in
> decompressor for arm64, as we defer to the bootloader to handle that for us
> instead. The Image.gz target already produces a gzipped kernel payload.
>
> What are you trying to do?


Yeah silly me, yet having a different behavior while installing: make 
zinstall <-> make install in comparison to x86 is misleading. Maybe this 
could be an option in the K config?

Greetings,

Tobias
diff mbox series

Patch

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index a4168d366127..91a5e1cd7279 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -140,6 +140,11 @@  config ARM64
 	select HAVE_GENERIC_DMA_COHERENT
 	select HAVE_HW_BREAKPOINT if PERF_EVENTS
 	select HAVE_IRQ_TIME_ACCOUNTING
+	select HAVE_KERNEL_GZIP
+	select HAVE_KERNEL_LZ4
+	select HAVE_KERNEL_LZMA
+	select HAVE_KERNEL_LZO
+	select HAVE_KERNEL_XZ
 	select HAVE_MEMBLOCK_NODE_MAP if NUMA
 	select HAVE_NMI
 	select HAVE_PATA_PLATFORM