[PATCH/RFC,01/02] arm64: dts: renesas: r8a7795: Remove IMR-LX4 device nodes
diff mbox series

Message ID 154807140504.25511.16758316156851099392.sendpatchset@octo
State Under Review
Delegated to: Simon Horman
Headers show
Series
  • Remove undocumented IMR-LX4 device nodes
Related show

Commit Message

Magnus Damm Jan. 21, 2019, 11:50 a.m. UTC
From: Magnus Damm <damm+renesas@opensource.se>

Get rid of undocumented IMR-LX4 device nodes for the r8a7795 SoC.

I would much prefer to have a proper driver with documented DT bindings
in upstream instead. However removing DT nodes seems better than this
current half-way state.

Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---

 arch/arm64/boot/dts/renesas/r8a7795.dtsi |   40 ------------------------------
 1 file changed, 40 deletions(-)

Comments

Simon Horman Jan. 23, 2019, 9:59 a.m. UTC | #1
On Mon, Jan 21, 2019 at 08:50:05PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
> 
> Get rid of undocumented IMR-LX4 device nodes for the r8a7795 SoC.
> 
> I would much prefer to have a proper driver with documented DT bindings
> in upstream instead. However removing DT nodes seems better than this
> current half-way state.
> 
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>

I agree, likewise for patch 02/02.

Shall I go ahead and apply this series?

> ---
> 
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi |   40 ------------------------------
>  1 file changed, 40 deletions(-)
> 
> --- 0001/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ work/arch/arm64/boot/dts/renesas/r8a7795.dtsi	2019-01-21 17:48:16.337551506 +0900
> @@ -2607,46 +2607,6 @@
>  			status = "disabled";
>  		};
>  
> -		imr-lx4@fe860000 {
> -			compatible = "renesas,r8a7795-imr-lx4",
> -				     "renesas,imr-lx4";
> -			reg = <0 0xfe860000 0 0x2000>;
> -			interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&cpg CPG_MOD 823>;
> -			power-domains = <&sysc R8A7795_PD_A3VC>;
> -			resets = <&cpg 823>;
> -		};
> -
> -		imr-lx4@fe870000 {
> -			compatible = "renesas,r8a7795-imr-lx4",
> -				     "renesas,imr-lx4";
> -			reg = <0 0xfe870000 0 0x2000>;
> -			interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&cpg CPG_MOD 822>;
> -			power-domains = <&sysc R8A7795_PD_A3VC>;
> -			resets = <&cpg 822>;
> -		};
> -
> -		imr-lx4@fe880000 {
> -			compatible = "renesas,r8a7795-imr-lx4",
> -				     "renesas,imr-lx4";
> -			reg = <0 0xfe880000 0 0x2000>;
> -			interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&cpg CPG_MOD 821>;
> -			power-domains = <&sysc R8A7795_PD_A3VC>;
> -			resets = <&cpg 821>;
> -		};
> -
> -		imr-lx4@fe890000 {
> -			compatible = "renesas,r8a7795-imr-lx4",
> -				     "renesas,imr-lx4";
> -			reg = <0 0xfe890000 0 0x2000>;
> -			interrupts = <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&cpg CPG_MOD 820>;
> -			power-domains = <&sysc R8A7795_PD_A3VC>;
> -			resets = <&cpg 820>;
> -		};
> -
>  		fdp1@fe940000 {
>  			compatible = "renesas,fdp1";
>  			reg = <0 0xfe940000 0 0x2400>;
>
Sergei Shtylyov Jan. 23, 2019, 3:43 p.m. UTC | #2
On 01/23/2019 12:59 PM, Simon Horman wrote:

>> From: Magnus Damm <damm+renesas@opensource.se>
>>
>> Get rid of undocumented IMR-LX4 device nodes for the r8a7795 SoC.
>>
>> I would much prefer to have a proper driver with documented DT bindings
>> in upstream instead. However removing DT nodes seems better than this
>> current half-way state.
>>
>> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> 
> I agree, likewise for patch 02/02.
> 
> Shall I go ahead and apply this series?

   I will return to the IMR driver after I'm done with V3M/V3H (and I have the HyperFlash
driver to push upstream yet for those). Sorry for dropping the ball here, it wasn't my fault.

MBR, Sergei

Patch
diff mbox series

--- 0001/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ work/arch/arm64/boot/dts/renesas/r8a7795.dtsi	2019-01-21 17:48:16.337551506 +0900
@@ -2607,46 +2607,6 @@ 
 			status = "disabled";
 		};
 
-		imr-lx4@fe860000 {
-			compatible = "renesas,r8a7795-imr-lx4",
-				     "renesas,imr-lx4";
-			reg = <0 0xfe860000 0 0x2000>;
-			interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&cpg CPG_MOD 823>;
-			power-domains = <&sysc R8A7795_PD_A3VC>;
-			resets = <&cpg 823>;
-		};
-
-		imr-lx4@fe870000 {
-			compatible = "renesas,r8a7795-imr-lx4",
-				     "renesas,imr-lx4";
-			reg = <0 0xfe870000 0 0x2000>;
-			interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&cpg CPG_MOD 822>;
-			power-domains = <&sysc R8A7795_PD_A3VC>;
-			resets = <&cpg 822>;
-		};
-
-		imr-lx4@fe880000 {
-			compatible = "renesas,r8a7795-imr-lx4",
-				     "renesas,imr-lx4";
-			reg = <0 0xfe880000 0 0x2000>;
-			interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&cpg CPG_MOD 821>;
-			power-domains = <&sysc R8A7795_PD_A3VC>;
-			resets = <&cpg 821>;
-		};
-
-		imr-lx4@fe890000 {
-			compatible = "renesas,r8a7795-imr-lx4",
-				     "renesas,imr-lx4";
-			reg = <0 0xfe890000 0 0x2000>;
-			interrupts = <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>;
-			clocks = <&cpg CPG_MOD 820>;
-			power-domains = <&sysc R8A7795_PD_A3VC>;
-			resets = <&cpg 820>;
-		};
-
 		fdp1@fe940000 {
 			compatible = "renesas,fdp1";
 			reg = <0 0xfe940000 0 0x2400>;