| Message ID | 20190121142134.17434-5-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] drm/i915/crt: split out intel_crt_present() to platform specific setup | expand |
On Mon, Jan 21, 2019 at 04:21:34PM +0200, Jani Nikula wrote: > Clarify that the name is specific to PCH platforms. > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 6960004fdc94..32270d7b71b9 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -14231,7 +14231,7 @@ static int intel_encoder_clones(struct intel_encoder *encoder) > return index_mask; > } > > -static bool has_edp_a(struct drm_i915_private *dev_priv) > +static bool intel_pch_has_edp_a(struct drm_i915_private *dev_priv) Hmm. The port is on the CPU though. The function name reads more like it's looking for port A on the PCH now. ilk_has_edp_a() maybe? > { > if (!IS_MOBILE(dev_priv)) > return false; > @@ -14385,7 +14385,7 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) > > dpd_is_edp = intel_dp_is_port_edp(dev_priv, PORT_D); > > - if (has_edp_a(dev_priv)) > + if (intel_pch_has_edp_a(dev_priv)) > intel_dp_init(dev_priv, DP_A, PORT_A); > > if (I915_READ(PCH_HDMIB) & SDVO_DETECTED) { > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 6960004fdc94..32270d7b71b9 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -14231,7 +14231,7 @@ static int intel_encoder_clones(struct intel_encoder *encoder) return index_mask; } -static bool has_edp_a(struct drm_i915_private *dev_priv) +static bool intel_pch_has_edp_a(struct drm_i915_private *dev_priv) { if (!IS_MOBILE(dev_priv)) return false; @@ -14385,7 +14385,7 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) dpd_is_edp = intel_dp_is_port_edp(dev_priv, PORT_D); - if (has_edp_a(dev_priv)) + if (intel_pch_has_edp_a(dev_priv)) intel_dp_init(dev_priv, DP_A, PORT_A); if (I915_READ(PCH_HDMIB) & SDVO_DETECTED) {
Clarify that the name is specific to PCH platforms. Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)