From patchwork Tue Jan 22 15:21:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10775737 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DF6056C2 for ; Tue, 22 Jan 2019 15:23:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE4EA28505 for ; Tue, 22 Jan 2019 15:23:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C23962AEAD; Tue, 22 Jan 2019 15:23:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6915028505 for ; Tue, 22 Jan 2019 15:23:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2FB98E0007; Tue, 22 Jan 2019 10:23:22 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id EDF5F8E0001; Tue, 22 Jan 2019 10:23:22 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D86EA8E0007; Tue, 22 Jan 2019 10:23:22 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by kanga.kvack.org (Postfix) with ESMTP id A41EA8E0001 for ; Tue, 22 Jan 2019 10:23:22 -0500 (EST) Received: by mail-pf1-f198.google.com with SMTP id t2so18504593pfj.15 for ; Tue, 22 Jan 2019 07:23:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:mime-version:content-transfer-encoding; bh=eBBWgX5fdT3kZ04KelGFlYpklJDbL166nuEPyGRzy6M=; b=iL1RvVEObA+tWcFXFlThbFMvz8Dom8yTsyxuG66EJEet1TgVYAkAo1sEDra6WZeaDY yNhUgu1TVbflGGx619/H4R5sy0fTvs+VQsuIjSoxOmgX+y4IXHIJ1e4G6ozoPk4mO4kh Jg2CIjlXkTtA2LbRkTX62HxcNDxZGWgfjfQp9POFNm7pVyWa3vS46v/FjsTZszKv7B8C VrxBlb2ALdSp4ijHRPUnV2cw5SRdrayZ3w6ae8b2hcsA6eG+TC7iLRwRSyMTPEtLLWMp XxEzy6PjgmIE38rRgbj+Rqyz7VjQWrbcGauyHc9+tF4gp10CIf+yb+ZPU2Qgn6TjG2E2 jx6A== X-Gm-Message-State: AJcUukdL0JN/ofr9kdA4N8xV9TtdM+nyI3qmODWt+k7NA3hE8mDNfgT4 3BYT7Ta6GgPJxUIfo/SKOhZ0yprx5pCnUCTYcKncM8I2NiioqhYI6LeJ25vVCmD5N2SpzaGidTC 205v/KXGz437xju+hRBRUp049vpbEC4NAqIqIpPLcvOWp9qPbBwyvm97jZZoIcjg= X-Received: by 2002:a62:140a:: with SMTP id 10mr33458392pfu.157.1548170602331; Tue, 22 Jan 2019 07:23:22 -0800 (PST) X-Google-Smtp-Source: ALg8bN72zmOz/HN+eKfwPGKPWpKDvQd0GqMsk/HTVcoEbWs4IU9sNDmaLA3kiPwcKnMM3Ka/4YWD X-Received: by 2002:a62:140a:: with SMTP id 10mr33458371pfu.157.1548170601816; Tue, 22 Jan 2019 07:23:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548170601; cv=none; d=google.com; s=arc-20160816; b=mwjvm0LjEkh9X6Vs4e82u/OSUtK6kNteHinLE1szcSv28ctV6vXqpEogheKKlTB2kS COawpZHYYAl+RdNzwk+O3/hjwKpLnFXt4ccBFYRnRTR2Cid4JfaaJSKsZRBF72iRE5LW RJ8yp4ay09uVAk6YqoPAFn2zfLb5RUTlS8mmEjgqEhHUMkH8rT0xHDDQvie1+JoA8R0q NbQGAAvEt8cdinP2Xal01jZlLDyE6t8RGAzZyISGLc9GtjZYoDEotmu9SdBQPKDhANBI z1IkrDLbHpgFKQv51AXCDSfe2MenhhwZnNsiXpTHeLo46ATxxthBMryrGg+pvAmMLUtA SsiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=eBBWgX5fdT3kZ04KelGFlYpklJDbL166nuEPyGRzy6M=; b=S1boxlQ7rfn4p138y3efhn3psyuR39WcartN/Bij77+bLuu8olPtl9ERoSCrGbzZs2 CeM9wuhbT/AE8gH1nvAhAWALkRbdUjqHEhEJlv7P5mivichW8K+MgJxOTnp1hPJ6t3SA 13xiCGO0jn5arTLWnbRI8b07r6QKhB7utuSTl/7ZNi+/BLAdCUo4ILY7aHg1mkVkiCle 2gTL9W4XbsYvxw9UMWhflOC2Gdr5ozoyk1YQF+KgAwsvBVJfi3ZW4XRMGUVqr2ROaXxS PQp7yUScNeyY+xVCqH22prMSVlNeN1f9PFYgMnBf5MI5voczX8hZqAHGcknLSgdIjkun SmsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UAP1p59s; spf=pass (google.com: domain of srs0=915k=p6=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom="SRS0=915k=P6=linuxfoundation.org=gregkh@kernel.org" Received: from mail.kernel.org (mail.kernel.org. [198.145.29.99]) by mx.google.com with ESMTPS id q9si16811659pgi.89.2019.01.22.07.23.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 07:23:21 -0800 (PST) Received-SPF: pass (google.com: domain of srs0=915k=p6=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) client-ip=198.145.29.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UAP1p59s; spf=pass (google.com: domain of srs0=915k=p6=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom="SRS0=915k=P6=linuxfoundation.org=gregkh@kernel.org" Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 03629217D4; Tue, 22 Jan 2019 15:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548170601; bh=UgFdE/28zUYcD+pvmTGjHV58/a6MidScMZkcvO2bYic=; h=From:To:Cc:Subject:Date:From; b=UAP1p59slyM3EvNUqs1zTQ0f6zFHKYC3c5EhxMzKKgXjLzYbq5TNb1PDD0nZB5glv 5SBD5pbzmaI+Rszx9vfpoTrUS+/7aNP9UBHEIvFAPqxvM/DIOj9mwEY6LGzm8NqFfw ACPw78H0DmV3wrNel1QrnnlNuHcMcFoh2dwGEvlU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Seth Jennings , Dan Streetman , linux-mm@kvack.org Subject: [PATCH] zswap: ignore debugfs_create_dir() return value Date: Tue, 22 Jan 2019 16:21:08 +0100 Message-Id: <20190122152151.16139-9-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Seth Jennings Cc: Dan Streetman Cc: linux-mm@kvack.org Signed-off-by: Greg Kroah-Hartman Acked-by: Dan Streetman --- mm/zswap.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index a4e4d36ec085..f583d08f6e24 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1262,8 +1262,6 @@ static int __init zswap_debugfs_init(void) return -ENODEV; zswap_debugfs_root = debugfs_create_dir("zswap", NULL); - if (!zswap_debugfs_root) - return -ENOMEM; debugfs_create_u64("pool_limit_hit", 0444, zswap_debugfs_root, &zswap_pool_limit_hit);