[v2,6/6] arm64: dts: renesas: r8a77995: draak: Enable LVDS1 encoder
diff mbox series

Message ID 20190122225405.7815-7-laurent.pinchart+renesas@ideasonboard.com
State Accepted
Commit 9a0ff5c727b60a3afefc71407612e515f7a51ef3
Delegated to: Simon Horman
Headers show
Series
  • R-Car DU DPAD support for D3 and E3
Related show

Commit Message

Laurent Pinchart Jan. 22, 2019, 10:54 p.m. UTC
The LVDS1 encoder must supply a pixel clock to the DU for the DPAD
output when the LVDS0 encoder is used. Enable it despite its output not
being connected.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
Changes since v1:

- Add a comment in the DT to explain why the LVDS1 encoder needs to be
  enabled.
---
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Simon Horman Jan. 23, 2019, 8:57 a.m. UTC | #1
On Wed, Jan 23, 2019 at 12:54:05AM +0200, Laurent Pinchart wrote:
> The LVDS1 encoder must supply a pixel clock to the DU for the DPAD
> output when the LVDS0 encoder is used. Enable it despite its output not
> being connected.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> Changes since v1:
> 
> - Add a comment in the DT to explain why the LVDS1 encoder needs to be
>   enabled.

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index 89df9bc844c0..3c9ec67e342b 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -356,6 +356,13 @@ 
 };
 
 &lvds1 {
+	/*
+	 * Even though the LVDS1 output is not connected, the encoder must be
+	 * enabled to supply a pixel clock to the DU for the DPAD output when
+	 * LVDS0 is in use.
+	 */
+	status = "okay";
+
 	clocks = <&cpg CPG_MOD 727>,
 		 <&x12_clk>,
 		 <&extal_clk>;