| Message ID | 20190123152310.11680-6-angus@akkea.ca (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dma: imx-sdma: add the sdma engine to the imx8mq | expand |
Am Mittwoch, den 23.01.2019, 08:23 -0700 schrieb Angus Ainslie (Purism): > Add the sdma nodes to the base devicetree for the imx8mq > > > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 31 +++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index c0402375e7c1..4397992fd021 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -336,6 +336,19 @@ > > clocks = <&clk IMX8MQ_CLK_WDOG3_ROOT>; > > status = "disabled"; > > }; > + > > > + sdma2: sdma@302c0000 { > > + compatible = "fsl,imx8mq-sdma", "fsl,imx7d-sdma"; > > + reg = <0x302c0000 0x10000>; > > + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clk IMX8MQ_CLK_SDMA2_ROOT>, > > + <&clk IMX8MQ_CLK_SDMA2_ROOT>; > > + clock-names = "ipg", "ahb"; > > + #dma-cells = <3>; > > + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; > + fsl,ratio-1-1; Property does not exist anymore. > + status = "disabled"; SoC peripherals that have no outside connection and thus don't depend on any board level configuration should always be enabled. Please drop this status property. > + }; > > }; > > > bus@30400000 { /* AIPS2 */ > @@ -370,6 +383,8 @@ > > clocks = <&clk IMX8MQ_CLK_UART3_ROOT>, > > <&clk IMX8MQ_CLK_UART3_ROOT>; > > clock-names = "ipg", "per"; > > + dmas = <&sdma1 26 4 0>, <&sdma1 27 4 0>; > > + dma-names = "rx", "tx"; > > status = "disabled"; > > }; > > @@ -381,6 +396,8 @@ > > clocks = <&clk IMX8MQ_CLK_UART2_ROOT>, > > <&clk IMX8MQ_CLK_UART2_ROOT>; > > clock-names = "ipg", "per"; > > + dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>; > > + dma-names = "rx", "tx"; > > status = "disabled"; > > }; > > @@ -432,6 +449,8 @@ > > clocks = <&clk IMX8MQ_CLK_UART4_ROOT>, > > <&clk IMX8MQ_CLK_UART4_ROOT>; > > clock-names = "ipg", "per"; > > + dmas = <&sdma1 28 4 0>, <&sdma1 29 4 0>; > > + dma-names = "rx", "tx"; > > status = "disabled"; > > }; > > @@ -465,6 +484,18 @@ > > status = "disabled"; > > }; > > > > + sdma1: sdma@30bd0000 { > > + compatible = "fsl,imx8mq-sdma", "fsl,imx7d-sdma"; > > + reg = <0x30bd0000 0x10000>; > > + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&clk IMX8MQ_CLK_SDMA1_ROOT>, > > + <&clk IMX8MQ_CLK_AHB>; > > + clock-names = "ipg", "ahb"; > > + #dma-cells = <3>; > > + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; > + status = "disabled"; Same comment as above, this node should be enabled by default. Regards, Lucas > + }; > + > > > fec1: ethernet@30be0000 { > > compatible = "fsl,imx8mq-fec", "fsl,imx6sx-fec"; > > reg = <0x30be0000 0x10000>;
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index c0402375e7c1..4397992fd021 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -336,6 +336,19 @@ clocks = <&clk IMX8MQ_CLK_WDOG3_ROOT>; status = "disabled"; }; + + sdma2: sdma@302c0000 { + compatible = "fsl,imx8mq-sdma", "fsl,imx7d-sdma"; + reg = <0x302c0000 0x10000>; + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MQ_CLK_SDMA2_ROOT>, + <&clk IMX8MQ_CLK_SDMA2_ROOT>; + clock-names = "ipg", "ahb"; + #dma-cells = <3>; + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; + fsl,ratio-1-1; + status = "disabled"; + }; }; bus@30400000 { /* AIPS2 */ @@ -370,6 +383,8 @@ clocks = <&clk IMX8MQ_CLK_UART3_ROOT>, <&clk IMX8MQ_CLK_UART3_ROOT>; clock-names = "ipg", "per"; + dmas = <&sdma1 26 4 0>, <&sdma1 27 4 0>; + dma-names = "rx", "tx"; status = "disabled"; }; @@ -381,6 +396,8 @@ clocks = <&clk IMX8MQ_CLK_UART2_ROOT>, <&clk IMX8MQ_CLK_UART2_ROOT>; clock-names = "ipg", "per"; + dmas = <&sdma1 24 4 0>, <&sdma1 25 4 0>; + dma-names = "rx", "tx"; status = "disabled"; }; @@ -432,6 +449,8 @@ clocks = <&clk IMX8MQ_CLK_UART4_ROOT>, <&clk IMX8MQ_CLK_UART4_ROOT>; clock-names = "ipg", "per"; + dmas = <&sdma1 28 4 0>, <&sdma1 29 4 0>; + dma-names = "rx", "tx"; status = "disabled"; }; @@ -465,6 +484,18 @@ status = "disabled"; }; + sdma1: sdma@30bd0000 { + compatible = "fsl,imx8mq-sdma", "fsl,imx7d-sdma"; + reg = <0x30bd0000 0x10000>; + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MQ_CLK_SDMA1_ROOT>, + <&clk IMX8MQ_CLK_AHB>; + clock-names = "ipg", "ahb"; + #dma-cells = <3>; + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; + status = "disabled"; + }; + fec1: ethernet@30be0000 { compatible = "fsl,imx8mq-fec", "fsl,imx6sx-fec"; reg = <0x30be0000 0x10000>;
Add the sdma nodes to the base devicetree for the imx8mq Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 31 +++++++++++++++++++++++ 1 file changed, 31 insertions(+)