| Message ID | 20190123172740.32452-17-berrange@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | chardev: refactoring & many bugfixes related tcp_chr_wait_connected | expand |
On Wed, Jan 23, 2019 at 6:29 PM Daniel P. Berrangé <berrange@redhat.com> wrote: > > valgrind on the test-char.c code reports that 'struct termios' contains > uninitialized memory. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > chardev/char-serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/chardev/char-serial.c b/chardev/char-serial.c > index 3299b46853..a8bae31b8d 100644 > --- a/chardev/char-serial.c > +++ b/chardev/char-serial.c > @@ -57,7 +57,7 @@ static void qmp_chardev_open_serial(Chardev *chr, > static void tty_serial_init(int fd, int speed, > int parity, int data_bits, int stop_bits) > { > - struct termios tty; > + struct termios tty = {0}; > speed_t spd; > > #if 0 > -- > 2.20.1 >
diff --git a/chardev/char-serial.c b/chardev/char-serial.c index 3299b46853..a8bae31b8d 100644 --- a/chardev/char-serial.c +++ b/chardev/char-serial.c @@ -57,7 +57,7 @@ static void qmp_chardev_open_serial(Chardev *chr, static void tty_serial_init(int fd, int speed, int parity, int data_bits, int stop_bits) { - struct termios tty; + struct termios tty = {0}; speed_t spd; #if 0
valgrind on the test-char.c code reports that 'struct termios' contains uninitialized memory. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- chardev/char-serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)