PCI: dra7xx: Invoke phy_set_mode API to set PHY mode to PHY_MODE_PCIE
diff mbox series

Message ID 20190124104537.22271-1-kishon@ti.com
State New
Headers show
Series
  • PCI: dra7xx: Invoke phy_set_mode API to set PHY mode to PHY_MODE_PCIE
Related show

Commit Message

Kishon Vijay Abraham I Jan. 24, 2019, 10:45 a.m. UTC
Certain PHYs used with PCIe controller can also be used with other
controllers such as USB or SATA. In order to configure the PHY
to work with PCIe controller, invoke phy_set_mode API with mode
set to PHY_MODE_PCIE.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/pci/controller/dwc/pci-dra7xx.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Lorenzo Pieralisi Jan. 31, 2019, 5:29 p.m. UTC | #1
On Thu, Jan 24, 2019 at 04:15:37PM +0530, Kishon Vijay Abraham I wrote:
> Certain PHYs used with PCIe controller can also be used with other
> controllers such as USB or SATA. In order to configure the PHY
> to work with PCIe controller, invoke phy_set_mode API with mode
> set to PHY_MODE_PCIE.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/pci/controller/dwc/pci-dra7xx.c | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to pci/dwc for v5.1, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
> index efb26096ccb5..b287dbf6914c 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -517,6 +517,10 @@ static int dra7xx_pcie_enable_phy(struct dra7xx_pcie *dra7xx)
>  	int i;
>  
>  	for (i = 0; i < phy_count; i++) {
> +		ret = phy_set_mode(dra7xx->phy[i], PHY_MODE_PCIE);
> +		if (ret < 0)
> +			goto err_phy;
> +
>  		ret = phy_init(dra7xx->phy[i]);
>  		if (ret < 0)
>  			goto err_phy;
> -- 
> 2.17.1
>

Patch
diff mbox series

diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
index efb26096ccb5..b287dbf6914c 100644
--- a/drivers/pci/controller/dwc/pci-dra7xx.c
+++ b/drivers/pci/controller/dwc/pci-dra7xx.c
@@ -517,6 +517,10 @@  static int dra7xx_pcie_enable_phy(struct dra7xx_pcie *dra7xx)
 	int i;
 
 	for (i = 0; i < phy_count; i++) {
+		ret = phy_set_mode(dra7xx->phy[i], PHY_MODE_PCIE);
+		if (ret < 0)
+			goto err_phy;
+
 		ret = phy_init(dra7xx->phy[i]);
 		if (ret < 0)
 			goto err_phy;