| Message ID | 20190124125138.7131-1-p.zabel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] drm/imx: imx-tve: depend on COMMON_CLK | expand |
On Thu, Jan 24, 2019 at 1:51 PM Philipp Zabel <p.zabel@pengutronix.de> wrote: > Since the TVE provides a clock to the DI, the driver can only be > compiled if the common clock framework is enabled. With the COMMON_CLK > dependency in place, it will be possible to allow building the other > parts of imx-drm under COMPILE_TEST on architectures that do not select > the common clock framework. > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Since the clock framework has stubs I bet it can be *compiled* without COMMON_CLK. But it will certainly not work so if you reword the commit: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Hi Linus, On Wed, 2019-01-30 at 09:16 +0100, Linus Walleij wrote: > On Thu, Jan 24, 2019 at 1:51 PM Philipp Zabel <p.zabel@pengutronix.de> wrote: > > > Since the TVE provides a clock to the DI, the driver can only be > > compiled if the common clock framework is enabled. With the COMMON_CLK > > dependency in place, it will be possible to allow building the other > > parts of imx-drm under COMPILE_TEST on architectures that do not select > > the common clock framework. > > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > > Since the clock framework has stubs I bet it can be *compiled* without > COMMON_CLK. But it will certainly not work so if you reword the commit: > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> thank you for the review. It indeed does not compile because struct imx_tve embeds a struct clk_hw, which is defined in linux/clk-provider.h only if COMMON_CLK is enabled. regards Philipp
On Wed, Jan 30, 2019 at 10:01 AM Philipp Zabel <p.zabel@pengutronix.de> wrote: > On Wed, 2019-01-30 at 09:16 +0100, Linus Walleij wrote: > > On Thu, Jan 24, 2019 at 1:51 PM Philipp Zabel <p.zabel@pengutronix.de> wrote: > > > > > Since the TVE provides a clock to the DI, the driver can only be > > > compiled if the common clock framework is enabled. With the COMMON_CLK > > > dependency in place, it will be possible to allow building the other > > > parts of imx-drm under COMPILE_TEST on architectures that do not select > > > the common clock framework. > > > > > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> > > > > Since the clock framework has stubs I bet it can be *compiled* without > > COMMON_CLK. But it will certainly not work so if you reword the commit: > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > thank you for the review. It indeed does not compile because struct > imx_tve embeds a struct clk_hw, which is defined in linux/clk-provider.h > only if COMMON_CLK is enabled. Oh that one, I see it is a clock driver. Sorry for my ignorance. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig index c9e439c82241..c55428490e56 100644 --- a/drivers/gpu/drm/imx/Kconfig +++ b/drivers/gpu/drm/imx/Kconfig @@ -18,6 +18,7 @@ config DRM_IMX_PARALLEL_DISPLAY config DRM_IMX_TVE tristate "Support for TV and VGA displays" depends on DRM_IMX + depends on COMMON_CLK select REGMAP_MMIO help Choose this to enable the internal Television Encoder (TVe)
Since the TVE provides a clock to the DI, the driver can only be compiled if the common clock framework is enabled. With the COMMON_CLK dependency in place, it will be possible to allow building the other parts of imx-drm under COMPILE_TEST on architectures that do not select the common clock framework. Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> --- drivers/gpu/drm/imx/Kconfig | 1 + 1 file changed, 1 insertion(+)