From patchwork Thu Jan 24 16:58:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10779561 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 53973139A for ; Thu, 24 Jan 2019 16:59:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 887DE304B4 for ; Thu, 24 Jan 2019 16:59:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7AC1D30586; Thu, 24 Jan 2019 16:59:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3E040304B4 for ; Thu, 24 Jan 2019 16:59:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD1806F1C2; Thu, 24 Jan 2019 16:58:54 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67F556F1C0 for ; Thu, 24 Jan 2019 16:58:48 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id o10so5119214edt.13 for ; Thu, 24 Jan 2019 08:58:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7M2ZC/JIAdJk9xcSb0yBwA5QAFfYAqBpqs4DXx4c4LA=; b=gPHBJl/feZfX1JbBZthEKdjiVjllq483P57KF2MzlnCCyXt1rH9uTeg0vBcaCnh8Y3 3L3qI0xuQmWRT8f2qyXv0xSJK/9xqaJlylPtgUZSpudEkkBIEa9MYO/IU4JbQTbUJufS kZabDKU4RYAb/9Et2ktBY4Uc9m/rTbg9mLIFs41y4wh4np6g8hMhB8PWKwdFozVpJ9ka q8EmKk73l/eB/sWsCR4md3RGwGDN3UhPVgO1Oy9tbEQasZNQ4yWyv1HKcQ2biSF2EyAE n4M//5wfp2vcRFtI8FAaR+edLVtnf//dFQw/nT/rxybCVXD1bo9oZdV9L+w/velUDeyi 46gA== X-Gm-Message-State: AJcUukcn4cpUl7COIRNEwtd6aT+wH+HdkssbwCqcjd33Pk5QisgWJ26X gaxpFaHR3e75Y0AOhf5pbG3UyVS3O3s= X-Google-Smtp-Source: ALg8bN6psB3OG7+yRHRspB5HKhd6sk3YBzLGz3/tjamtjYlwUqHmv944/cVkj4r89A4m0Jo+KZCHxA== X-Received: by 2002:a17:906:118c:: with SMTP id n12mr2142390eja.228.1548349126654; Thu, 24 Jan 2019 08:58:46 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id w31sm11219233edw.82.2019.01.24.08.58.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:58:45 -0800 (PST) From: Daniel Vetter To: DRI Development Date: Thu, 24 Jan 2019 17:58:10 +0100 Message-Id: <20190124165831.16427-6-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124165831.16427-1-daniel.vetter@ffwll.ch> References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 05/26] drm/fb-helper: set fbi->fix.id in fill_info() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Looking at the oldest/most popular drivers ${driver}drmfb seems to be the standard, except i915.ko went with "inteldrmfb". I guess renaming that for consistency won't hurt, it definitely confused me when I started with kms 10 years ago. I hope this never became uapi ... worst case drivers can overwrite it after having called fill_info(). Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 34c4ed378796..20969c05a9e3 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -2126,6 +2126,9 @@ void drm_fb_helper_fill_info(struct fb_info *info, drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth); drm_fb_helper_fill_var(info, fb_helper, fb->width, fb->height); + snprintf(info->fix.id, sizeof(info->fix.id), "%sdrmfb", + fb_helper->dev->driver->name); + } EXPORT_SYMBOL(drm_fb_helper_fill_info); @@ -3185,8 +3188,6 @@ int drm_fb_helper_generic_probe(struct drm_fb_helper *fb_helper, fbi->fix.smem_start = page_to_phys(virt_to_page(fbi->screen_buffer)); #endif - strcpy(fbi->fix.id, "DRM emulated"); - drm_fb_helper_fill_info(fbi, fb_helper); if (fb->funcs->dirty) {