From patchwork Thu Jan 24 16:58:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10779641 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 847E3746 for ; Thu, 24 Jan 2019 17:00:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 125493120B for ; Thu, 24 Jan 2019 17:00:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 05E853123B; Thu, 24 Jan 2019 17:00:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B1EEA31241 for ; Thu, 24 Jan 2019 17:00:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 891476F1EC; Thu, 24 Jan 2019 16:59:22 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 606B86F1D4 for ; Thu, 24 Jan 2019 16:59:17 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id h15so5158310edb.4 for ; Thu, 24 Jan 2019 08:59:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h5x1S8E3k+BpZECaDGOeheSI+iJgHtELrrvxRcMDwWY=; b=HgjPTGCkqyiK/rz/YFDTnYhAfWpK8pnr7CM/x/vcicfYyUX7V+guLKFIAyp2DKrV4p E6D+SXTypKbrzDZIyZAaoJuHtYOCiZmErZaBRQY2165Eig///Zc/5PUJcFXXlSTMtJxl 6aiYkEPkanRM2oihF7saymDLHatb6pkfvPrW9SjqGoToHdoKFiX8czH31DgVnbI+Lq0z 0mY2C9BdFGaUztvFUrGBhh45T+G0br06fBKClgsbbjboZf0NFVMdkDulsV2BxXwRsIOo Sl3zHdqzn9N3o63XO/ibRbLb6CP4j4TS458DuZvZimVgkBSWF8k0HGmPMqTHrKc3tXNt F9aw== X-Gm-Message-State: AJcUukdcuRoKHs/OmL/11mdl7W+shOUWAgJNivWlNpe+VlV6EHN/qULB IfgB7tjAGKG7Un1aOzQ+rPPZAA== X-Google-Smtp-Source: ALg8bN6suUfap9nlqD26QQlCcnPzhbAi4w75eEdHLroSgvX/A0uC0IHJri/cFFhx/xesJHEOxgdfRA== X-Received: by 2002:a50:bf02:: with SMTP id f2mr7250238edk.157.1548349155120; Thu, 24 Jan 2019 08:59:15 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id w31sm11219233edw.82.2019.01.24.08.59.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:59:14 -0800 (PST) From: Daniel Vetter To: DRI Development Date: Thu, 24 Jan 2019 17:58:28 +0100 Message-Id: <20190124165831.16427-24-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124165831.16427-1-daniel.vetter@ffwll.ch> References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 23/26] drm/udl: Use drm_fb_helper_fill_info X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emil Lundmark , Greg Kroah-Hartman , Daniel Vetter , Intel Graphics Development , Mikulas Patocka , Daniel Vetter , Dave Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP This should not result in any changes. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Sean Paul Cc: Mikulas Patocka Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Emil Lundmark --- drivers/gpu/drm/udl/udl_fb.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c index dd9ffded223b..3e4804895d2e 100644 --- a/drivers/gpu/drm/udl/udl_fb.c +++ b/drivers/gpu/drm/udl/udl_fb.c @@ -32,7 +32,7 @@ module_param(fb_bpp, int, S_IWUSR | S_IRUSR | S_IWGRP | S_IRGRP); module_param(fb_defio, int, S_IWUSR | S_IRUSR | S_IWGRP | S_IRGRP); struct udl_fbdev { - struct drm_fb_helper helper; + struct drm_fb_helper helper; /* must be first */ struct udl_framebuffer ufb; int fb_count; }; @@ -402,15 +402,12 @@ static int udlfb_create(struct drm_fb_helper *helper, ufbdev->helper.fb = fb; - strcpy(info->fix.id, "udldrmfb"); - info->screen_base = ufbdev->ufb.obj->vmapping; info->fix.smem_len = size; info->fix.smem_start = (unsigned long)ufbdev->ufb.obj->vmapping; info->fbops = &udlfb_ops; - drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth); - drm_fb_helper_fill_var(info, &ufbdev->helper, sizes->fb_width, sizes->fb_height); + drm_fb_helper_fill_info(info, &ufbdev->helper); DRM_DEBUG_KMS("allocated %dx%d vmal %p\n", fb->width, fb->height,