[next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size
diff mbox series

Message ID 20190124170621.7583-1-colin.king@canonical.com
State New
Headers show
Series
  • [next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size
Related show

Commit Message

Colin King Jan. 24, 2019, 5:06 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Don't populate the const array mic_name on the stack but instead make
it static. Makes the object code smaller by 28 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  14107	   8832	    224	  23163	   5a7b	bytcht_es8316.o

After:
   text	   data	    bss	    dec	    hex	filename
  14015	   8896	    224	  23135	   5a5f	bytcht_es8316.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/soc/intel/boards/bytcht_es8316.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pierre-Louis Bossart Jan. 24, 2019, 5:27 p.m. UTC | #1
> diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
> index fa9c4cf97686..1364e4e601d8 100644
> --- a/sound/soc/intel/boards/bytcht_es8316.c
> +++ b/sound/soc/intel/boards/bytcht_es8316.c
> @@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping byt_cht_es8316_gpios[] = {
>   
>   static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
>   {
> -	const char * const mic_name[] = { "in1", "in2" };
> +	static const char * const mic_name[] = { "in1", "in2" };
>   	struct byt_cht_es8316_private *priv;
>   	struct device *dev = &pdev->dev;
>   	struct snd_soc_acpi_mach *mach;

We have the same code pattern in two other files, so if we care about 
this we should fix it across the board(s), no?

bytcht_es8316.c:    const char * const mic_name[] = { "in1", "in2" };
bytcr_rt5640.c:    const char * const map_name[] = { "dmic1", "dmic2", 
"in1", "in3" };
bytcr_rt5651.c:    const char * const mic_name[] = { "dmic", "in1", 
"in2", "in12" };
Colin King Jan. 24, 2019, 5:29 p.m. UTC | #2
On 24/01/2019 17:27, Pierre-Louis Bossart wrote:
> 
>> diff --git a/sound/soc/intel/boards/bytcht_es8316.c
>> b/sound/soc/intel/boards/bytcht_es8316.c
>> index fa9c4cf97686..1364e4e601d8 100644
>> --- a/sound/soc/intel/boards/bytcht_es8316.c
>> +++ b/sound/soc/intel/boards/bytcht_es8316.c
>> @@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping
>> byt_cht_es8316_gpios[] = {
>>     static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
>>   {
>> -    const char * const mic_name[] = { "in1", "in2" };
>> +    static const char * const mic_name[] = { "in1", "in2" };
>>       struct byt_cht_es8316_private *priv;
>>       struct device *dev = &pdev->dev;
>>       struct snd_soc_acpi_mach *mach;
> 
> We have the same code pattern in two other files, so if we care about
> this we should fix it across the board(s), no?
> 
> bytcht_es8316.c:    const char * const mic_name[] = { "in1", "in2" };
> bytcr_rt5640.c:    const char * const map_name[] = { "dmic1", "dmic2",
> "in1", "in3" };
> bytcr_rt5651.c:    const char * const mic_name[] = { "dmic", "in1",
> "in2", "in12" };
> 
Good point, will resend.

Colin

Patch
diff mbox series

diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
index fa9c4cf97686..1364e4e601d8 100644
--- a/sound/soc/intel/boards/bytcht_es8316.c
+++ b/sound/soc/intel/boards/bytcht_es8316.c
@@ -437,7 +437,7 @@  static const struct acpi_gpio_mapping byt_cht_es8316_gpios[] = {
 
 static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
 {
-	const char * const mic_name[] = { "in1", "in2" };
+	static const char * const mic_name[] = { "in1", "in2" };
 	struct byt_cht_es8316_private *priv;
 	struct device *dev = &pdev->dev;
 	struct snd_soc_acpi_mach *mach;