| Message ID | 20190124193101.24519-1-okaya@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
| Series | [for,next,v3,1/2] platform/x86: Fix unmet dependency warning for ACPI_CMPC | expand |
On Thu, Jan 24, 2019 at 9:31 PM Sinan Kaya <okaya@kernel.org> wrote: > > Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the > warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE. > > ACPI_CMPC selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE > depends on BACKLIGHT_LCD_SUPPORT. > > Copy BACKLIGHT_LCD_SUPPORT dependency into ACPI_CMPC to fix > > WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE > Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n] > Selected by [y]: > - ACPI_CMPC [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n) > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> for both patches in case Rafael takes care of them. > Signed-off-by: Sinan Kaya <okaya@kernel.org> > --- > drivers/platform/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 5e2109c54c7c..11810591840d 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -905,6 +905,7 @@ config TOSHIBA_WMI > config ACPI_CMPC > tristate "CMPC Laptop Extras" > depends on ACPI && INPUT > + depends on BACKLIGHT_LCD_SUPPORT > depends on RFKILL || RFKILL=n > select BACKLIGHT_CLASS_DEVICE > help > -- > 2.19.0 >
On Thursday, January 24, 2019 10:32:56 PM CET Andy Shevchenko wrote: > On Thu, Jan 24, 2019 at 9:31 PM Sinan Kaya <okaya@kernel.org> wrote: > > > > Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the > > warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE. > > > > ACPI_CMPC selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE > > depends on BACKLIGHT_LCD_SUPPORT. > > > > Copy BACKLIGHT_LCD_SUPPORT dependency into ACPI_CMPC to fix > > > > WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE > > Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n] > > Selected by [y]: > > - ACPI_CMPC [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n) > > > > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > for both patches in case Rafael takes care of them. So both applied, thanks!
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 5e2109c54c7c..11810591840d 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -905,6 +905,7 @@ config TOSHIBA_WMI config ACPI_CMPC tristate "CMPC Laptop Extras" depends on ACPI && INPUT + depends on BACKLIGHT_LCD_SUPPORT depends on RFKILL || RFKILL=n select BACKLIGHT_CLASS_DEVICE help
Add BACKLIGHT_LCD_SUPPORT for ACPI_CMPC to fix the warning: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE. ACPI_CMPC selects BACKLIGHT_CLASS_DEVICE but BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_LCD_SUPPORT. Copy BACKLIGHT_LCD_SUPPORT dependency into ACPI_CMPC to fix WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n] Selected by [y]: - ACPI_CMPC [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && INPUT [=y] && (RFKILL [=n] || RFKILL [=n]=n) Signed-off-by: Sinan Kaya <okaya@kernel.org> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)