[-next] selftests: bpf: remove duplicated include
diff mbox series

Message ID 20190125024634.14580-1-yuehaibing@huawei.com
State Mainlined
Commit cdd7b40642582f5130ea5ec20432175a70c8933e
Headers show
Series
  • [-next] selftests: bpf: remove duplicated include
Related show

Commit Message

YueHaibing Jan. 25, 2019, 2:46 a.m. UTC
Remove duplicated include.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 tools/testing/selftests/bpf/test_flow_dissector.c | 2 --
 tools/testing/selftests/bpf/test_maps.c           | 1 -
 tools/testing/selftests/bpf/test_sockmap.c        | 1 -
 3 files changed, 4 deletions(-)

Comments

Song Liu Jan. 25, 2019, 11:01 p.m. UTC | #1
On Thu, Jan 24, 2019 at 6:49 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Song Liu <songliubraving@fb.com>

Thanks!

> ---
>  tools/testing/selftests/bpf/test_flow_dissector.c | 2 --
>  tools/testing/selftests/bpf/test_maps.c           | 1 -
>  tools/testing/selftests/bpf/test_sockmap.c        | 1 -
>  3 files changed, 4 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
> index 12b784a..01f0c63 100644
> --- a/tools/testing/selftests/bpf/test_flow_dissector.c
> +++ b/tools/testing/selftests/bpf/test_flow_dissector.c
> @@ -16,7 +16,6 @@
>  #include <errno.h>
>  #include <linux/if_packet.h>
>  #include <linux/if_ether.h>
> -#include <linux/if_packet.h>
>  #include <linux/ipv6.h>
>  #include <netinet/ip.h>
>  #include <netinet/in.h>
> @@ -25,7 +24,6 @@
>  #include <stdbool.h>
>  #include <stdlib.h>
>  #include <stdio.h>
> -#include <stdlib.h>
>  #include <string.h>
>  #include <sys/ioctl.h>
>  #include <sys/socket.h>
> diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
> index e2b9eee..1dfef77 100644
> --- a/tools/testing/selftests/bpf/test_maps.c
> +++ b/tools/testing/selftests/bpf/test_maps.c
> @@ -633,7 +633,6 @@ static void test_stackmap(int task, void *data)
>         close(fd);
>  }
>
> -#include <sys/socket.h>
>  #include <sys/ioctl.h>
>  #include <arpa/inet.h>
>  #include <sys/select.h>
> diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
> index e85a771..3845144 100644
> --- a/tools/testing/selftests/bpf/test_sockmap.c
> +++ b/tools/testing/selftests/bpf/test_sockmap.c
> @@ -10,7 +10,6 @@
>  #include <unistd.h>
>  #include <string.h>
>  #include <errno.h>
> -#include <sys/ioctl.h>
>  #include <stdbool.h>
>  #include <signal.h>
>  #include <fcntl.h>
> --
> 2.7.0
>
>
Daniel Borkmann Jan. 28, 2019, 11:25 p.m. UTC | #2
On 01/25/2019 03:46 AM, YueHaibing wrote:
> Remove duplicated include.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied, thanks!

Patch
diff mbox series

diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
index 12b784a..01f0c63 100644
--- a/tools/testing/selftests/bpf/test_flow_dissector.c
+++ b/tools/testing/selftests/bpf/test_flow_dissector.c
@@ -16,7 +16,6 @@ 
 #include <errno.h>
 #include <linux/if_packet.h>
 #include <linux/if_ether.h>
-#include <linux/if_packet.h>
 #include <linux/ipv6.h>
 #include <netinet/ip.h>
 #include <netinet/in.h>
@@ -25,7 +24,6 @@ 
 #include <stdbool.h>
 #include <stdlib.h>
 #include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
 #include <sys/ioctl.h>
 #include <sys/socket.h>
diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
index e2b9eee..1dfef77 100644
--- a/tools/testing/selftests/bpf/test_maps.c
+++ b/tools/testing/selftests/bpf/test_maps.c
@@ -633,7 +633,6 @@  static void test_stackmap(int task, void *data)
 	close(fd);
 }
 
-#include <sys/socket.h>
 #include <sys/ioctl.h>
 #include <arpa/inet.h>
 #include <sys/select.h>
diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c
index e85a771..3845144 100644
--- a/tools/testing/selftests/bpf/test_sockmap.c
+++ b/tools/testing/selftests/bpf/test_sockmap.c
@@ -10,7 +10,6 @@ 
 #include <unistd.h>
 #include <string.h>
 #include <errno.h>
-#include <sys/ioctl.h>
 #include <stdbool.h>
 #include <signal.h>
 #include <fcntl.h>