From patchwork Sat Jan 26 06:32:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yizhuo Zhai X-Patchwork-Id: 10782339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1B8C491E for ; Sat, 26 Jan 2019 06:46:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 018D32EC04 for ; Sat, 26 Jan 2019 06:46:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6C0F2F33B; Sat, 26 Jan 2019 06:45:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 597A42EC04 for ; Sat, 26 Jan 2019 06:45:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbfAZGp6 (ORCPT ); Sat, 26 Jan 2019 01:45:58 -0500 Received: from mx1.ucr.edu ([138.23.248.2]:9317 "EHLO mx1.ucr.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbfAZGp6 (ORCPT ); Sat, 26 Jan 2019 01:45:58 -0500 X-Greylist: delayed 775 seconds by postgrey-1.27 at vger.kernel.org; Sat, 26 Jan 2019 01:45:57 EST DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ucr.edu; i=@ucr.edu; q=dns/txt; s=selector3; t=1548485157; x=1580021157; h=from:to:cc:subject:date:message-id; bh=spBmDIiF5jHQhSNgngoPo9qlEpmTF8uUh2cGxlBjoKg=; b=qQs1Pv4GhEs3CLCafGg1DS0FxiXWZEBwYQHtGmgQ1qR/F1YzSF//gKaO mJ6q9Ns5KhoCH//VwcOPJKHnoJ57U1lKsGilpveufvzCQqaOQTGbXrIfH RdKikPzax3oyK/4404XcBWdDT89MPQzEQm3hw8ORWik5JadSEm7BtDSru RRfS8BPAiDQ8t62rohpTpE4uKZsbmGeV5NXyHLELn9QFr4QiApdCyjuw5 D6zBGdHIMKS3yRX7PTxvUgD7ihTx9+nXOqIFvkfL4sOhmIHqatcrgmLJb 47jYUduyhRKaBBAjX37TXvElIdEOEPnlLBRtyJBzy8cx09mz00DQASDAy Q==; IronPort-PHdr: 9a23:0xiW8xTVOoQ1x9eM7zy4P0QbEdpsv+yvbD5Q0YIujvd0So/mwa69YxyN2/xhgRfzUJnB7Loc0qyK6/CmATRIyK3CmUhKSIZLWR4BhJdetC0bK+nBN3fGKuX3ZTcxBsVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+KPjrFY7OlcS30P2594HObwlSizexfbB/IA+qoQnNq8IbnZZsJqEtxxXTv3BGYf5WxWRmJVKSmxbz+MK994N9/ipTpvws6ddOXb31cKokQ7NYCi8mM30u683wqRbDVwqP6WACXWgQjxFFHhLK7BD+Xpf2ryv6qu9w0zSUMMHqUbw5Xymp4rx1QxH0ligIKz858HnWisNuiqJbvAmhrAF7z4LNfY2ZKOZycqbbcNMfRGpBRd1RVy1HAoOzcoABEfMPNvtWr4n8uVQOqQaxDhSoCO7h1jNEg3n71rA43es8CwHLxAwuEcwTvnrar9v7M7wfXfypwKTS0TnOde9a1Sv75YPVch4hu/aMXbdofMXTyEkuFgPFjkiXqYf4OD6U1uUMs2iB4OphSe6jl2Aqphpsojez3McgkJfGiZ8Iyl3d8yhy3YU7JcWgRUJlfdKpFIFcuiKaOodsXM8uXmFltDwkxrEapZK3ZDUGxZUjyhLFdfCKfYiF7gj9WOuQOzt1hn1odbSijBio60eg0PfzVsys3VZPqSpKj8fDu2gW1xzW9siHUvx9/lq92TqX1wDc9OVEIUcsmKreMZEhw7owmoMLsUTMAyP6gUv2gLGKekk44OSo5OPnYrLppp+YKYB4kB3xMqMrmsCnAOQ4NBYBX3SD9OiiyLHu+Vf1TbZKg/EsjKXVrZDXKd4FqqKlHwNZyoMj5Ay+Dzei3tQYh34HLFdddROHjonpO0vBIPHkAfujjVmhiypryOzcPrH7HJrCM2XDnK/7fblh805c1BYzzddH6pJQC7EBJu/zW0DouNzfCx82KRS0zv35CNVyyIweQ3iDAqyHP6PIt1+H+OYvL/OLZI8PtzauY9Y/4Pu7vH4rmUIaNf24z5seaSjgRdx7KF/fbHbx1IRSWVwWtxYzGbS5wGaJViReMjPtB68= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2ApAQDC/ktcf8jXVdFjHAECBAEIBAGBUgcBDAGEBQ+MG1+LFk8BAQEGimQYbYVXgnKFCoF7AQoBASyEQIMMIjQJDQEDAQECAQECARMBAQkLCwgnMYI6KYJfgQiBFQEFATVbgkcBgXQNnVo8jEqIVwEHgUsJAQiHboRBgQ+BB4NuhH+DVIJDAoEsAQEBj2yRJAEGAgGBY4FCjnskgzGGcIgHAS2adAIEAgQFAgUPIYElgg5NJYFsCoFEglGOLB4zgQeHWoJNAQ X-IPAS-Result: A2ApAQDC/ktcf8jXVdFjHAECBAEIBAGBUgcBDAGEBQ+MG1+LFk8BAQEGimQYbYVXgnKFCoF7AQoBASyEQIMMIjQJDQEDAQECAQECARMBAQkLCwgnMYI6KYJfgQiBFQEFATVbgkcBgXQNnVo8jEqIVwEHgUsJAQiHboRBgQ+BB4NuhH+DVIJDAoEsAQEBj2yRJAEGAgGBY4FCjnskgzGGcIgHAS2adAIEAgQFAgUPIYElgg5NJYFsCoFEglGOLB4zgQeHWoJNAQ X-IronPort-AV: E=Sophos;i="5.56,525,1539673200"; d="scan'208";a="1052417702" Received: from mail-pg1-f200.google.com ([209.85.215.200]) by smtp1.ucr.edu with ESMTP/TLS/AES128-GCM-SHA256; 25 Jan 2019 22:32:35 -0800 Received: by mail-pg1-f200.google.com with SMTP id g188so7691038pgc.22 for ; Fri, 25 Jan 2019 22:32:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yaf63aLCqjFpTNHGLnD1DlppPDZbRyd+ngLiTc70LIY=; b=JyG4Vet+rFogwqzZrTFnvLI+HDn9P9Tjf3iSmxM/t7faEYPoMLmfjDQW2cGtB5WzYp uClweSzjkKsUD+CB9IwZyYwIvgf/RUgQcME/pkxI8FMVEEYkkR7gtXjFzLwcZ+ie4Ckx Q8V8WzmtDM5gkzDipDu3XrYL9leFR25jXMjp+pyq3ASK0A2QQvz72uAvLM0AFpcIJnqY IWH8K58LF4XIkApmW1nPfYJNV6hrxa3Er47k4ALylQOf93mAg49XLpyQENom4OIULCRi TgP6cU+Mwbjhz8UFY4i4VlR40aVs0dM/2Y8MqGt2JIuAeLQVyUWfSc+WiEs8X1MFypSw 4E2w== X-Gm-Message-State: AJcUuke0bQR1R4eXH8yG12DWbNlfWhMYuzeCmtl6j0Akflrhvh0ZFeUq CAZMzYwO2kUa9KeAzB2O2clNvIdbniR9d4DLExZPjx3Tw7ZEy9cUYPwG1l5dOlwGNpJkEdQc5So J3KW55J7pHmFKld2OWynKHcQ= X-Received: by 2002:a17:902:9691:: with SMTP id n17mr14442969plp.9.1548484354983; Fri, 25 Jan 2019 22:32:34 -0800 (PST) X-Google-Smtp-Source: ALg8bN5YsCv7XKtB9I5a/bKPNYO+58A8UnKPAsilEc7mFrGw0e/Em5uRbQoHdzn94g45XXnYFhWVVA== X-Received: by 2002:a17:902:9691:: with SMTP id n17mr14442948plp.9.1548484354611; Fri, 25 Jan 2019 22:32:34 -0800 (PST) Received: from Yizhuo.cs.ucr.edu (yizhuo.cs.ucr.edu. [169.235.26.74]) by smtp.googlemail.com with ESMTPSA id c9sm51998403pfc.92.2019.01.25.22.32.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 22:32:33 -0800 (PST) From: Yizhuo Cc: csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo , Tony Lindgren , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: OMAP2+: Variable "reg" in function omap4_dsi_mux_pads() could be uninitialized Date: Fri, 25 Jan 2019 22:32:20 -0800 Message-Id: <20190126063221.8257-1-yzhai003@ucr.edu> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In function omap4_dsi_mux_pads(), local variable "reg" could be uninitialized if function regmap_read() returns -EINVAL. However, it will be used directly in the later context, which is potentially unsafe. Signed-off-by: Yizhuo --- arch/arm/mach-omap2/display.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index b3f6eb5d04a2..6e7440ef503a 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c @@ -84,6 +84,7 @@ static int omap4_dsi_mux_pads(int dsi_id, unsigned lanes) u32 enable_mask, enable_shift; u32 pipd_mask, pipd_shift; u32 reg; + int ret; if (dsi_id == 0) { enable_mask = OMAP4_DSI1_LANEENABLE_MASK; @@ -99,7 +100,11 @@ static int omap4_dsi_mux_pads(int dsi_id, unsigned lanes) return -ENODEV; } - regmap_read(omap4_dsi_mux_syscon, OMAP4_DSIPHY_SYSCON_OFFSET, ®); + ret = regmap_read(omap4_dsi_mux_syscon, + OMAP4_DSIPHY_SYSCON_OFFSET, + ®); + if (ret) + return ret; reg &= ~enable_mask; reg &= ~pipd_mask;