[1/3] Input: lpc32xx-key - add clocks property and fix DT binding example
diff mbox series

Message ID 20190126142921.16041-2-vz@mleia.com
State Accepted
Commit 24541dede9dbe0638c82ace2b072c08fd1ec786b
Headers show
Series
  • ARM: dts: lpc32xx: fix lpc32xx-key device node
Related show

Commit Message

Vladimir Zapolskiy Jan. 26, 2019, 2:29 p.m. UTC
The keypad controller on NXP LPC32xx requires its clock gate to be open,
therefore add description of the requires 'clocks' property.

In addition adjust the example by adding description of required 'clocks'
property and by fixing 'interrupts' property.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Vladimir Zapolskiy Jan. 30, 2019, 9:22 p.m. UTC | #1
Hi Rob, Dmitry,

On 01/26/2019 04:29 PM, Vladimir Zapolskiy wrote:
> The keypad controller on NXP LPC32xx requires its clock gate to be open,
> therefore add description of the requires 'clocks' property.
> 
> In addition adjust the example by adding description of required 'clocks'
> property and by fixing 'interrupts' property.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
>  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/lpc32xx-key.txt b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> index bcf62f856358..2b075a080d30 100644
> --- a/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> +++ b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> @@ -8,6 +8,7 @@ Required Properties:
>  - reg: Physical base address of the controller and length of memory mapped
>    region.
>  - interrupts: The interrupt number to the cpu.
> +- clocks: phandle to clock controller plus clock-specifier pair
>  - nxp,debounce-delay-ms: Debounce delay in ms
>  - nxp,scan-delay-ms: Repeated scan period in ms
>  - linux,keymap: the key-code to be reported when the key is pressed
> @@ -22,7 +23,9 @@ Example:
>  	key@40050000 {
>  		compatible = "nxp,lpc3220-key";
>  		reg = <0x40050000 0x1000>;
> -		interrupts = <54 0>;
> +		clocks = <&clk LPC32XX_CLK_KEY>;
> +		interrupt-parent = <&sic1>;
> +		interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
>  		keypad,num-rows = <1>;
>  		keypad,num-columns = <1>;
>  		nxp,debounce-delay-ms = <3>;
> 

if you find time, please review/ack this change before 5.0-rc5 to give
me a chance to push it through ARM tree, thank you in advance.

--
Best wishes,
Vladimir
Dmitry Torokhov Feb. 11, 2019, 10:52 p.m. UTC | #2
On Wed, Jan 30, 2019 at 11:22:40PM +0200, Vladimir Zapolskiy wrote:
> Hi Rob, Dmitry,
> 
> On 01/26/2019 04:29 PM, Vladimir Zapolskiy wrote:
> > The keypad controller on NXP LPC32xx requires its clock gate to be open,
> > therefore add description of the requires 'clocks' property.
> > 
> > In addition adjust the example by adding description of required 'clocks'
> > property and by fixing 'interrupts' property.
> > 
> > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> > ---
> >  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/lpc32xx-key.txt b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> > index bcf62f856358..2b075a080d30 100644
> > --- a/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> > +++ b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
> > @@ -8,6 +8,7 @@ Required Properties:
> >  - reg: Physical base address of the controller and length of memory mapped
> >    region.
> >  - interrupts: The interrupt number to the cpu.
> > +- clocks: phandle to clock controller plus clock-specifier pair
> >  - nxp,debounce-delay-ms: Debounce delay in ms
> >  - nxp,scan-delay-ms: Repeated scan period in ms
> >  - linux,keymap: the key-code to be reported when the key is pressed
> > @@ -22,7 +23,9 @@ Example:
> >  	key@40050000 {
> >  		compatible = "nxp,lpc3220-key";
> >  		reg = <0x40050000 0x1000>;
> > -		interrupts = <54 0>;
> > +		clocks = <&clk LPC32XX_CLK_KEY>;
> > +		interrupt-parent = <&sic1>;
> > +		interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> >  		keypad,num-rows = <1>;
> >  		keypad,num-columns = <1>;
> >  		nxp,debounce-delay-ms = <3>;
> > 
> 
> if you find time, please review/ack this change before 5.0-rc5 to give
> me a chance to push it through ARM tree, thank you in advance.

Sorry, I guess am a bit late, still, the binding is already used by the
driver so we should acknowledge it.

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Rob Herring Feb. 23, 2019, 12:41 a.m. UTC | #3
On Sat, 26 Jan 2019 16:29:19 +0200, Vladimir Zapolskiy wrote:
> The keypad controller on NXP LPC32xx requires its clock gate to be open,
> therefore add description of the requires 'clocks' property.
> 
> In addition adjust the example by adding description of required 'clocks'
> property and by fixing 'interrupts' property.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
>  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Vladimir Zapolskiy Feb. 23, 2019, 11:38 a.m. UTC | #4
Hi Dmitry,

On 02/23/2019 02:41 AM, Rob Herring wrote:
> On Sat, 26 Jan 2019 16:29:19 +0200, Vladimir Zapolskiy wrote:
>> The keypad controller on NXP LPC32xx requires its clock gate to be open,
>> therefore add description of the requires 'clocks' property.
>>
>> In addition adjust the example by adding description of required 'clocks'
>> property and by fixing 'interrupts' property.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>> ---
>>  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 

can you please pull this documentation change through Linux input branch?

The two other dts changes have been already included into arm-soc.

--
Best wishes,
Vladimir
Dmitry Torokhov April 3, 2019, 5:53 p.m. UTC | #5
On Sat, Feb 23, 2019 at 01:38:01PM +0200, Vladimir Zapolskiy wrote:
> Hi Dmitry,
> 
> On 02/23/2019 02:41 AM, Rob Herring wrote:
> > On Sat, 26 Jan 2019 16:29:19 +0200, Vladimir Zapolskiy wrote:
> >> The keypad controller on NXP LPC32xx requires its clock gate to be open,
> >> therefore add description of the requires 'clocks' property.
> >>
> >> In addition adjust the example by adding description of required 'clocks'
> >> property and by fixing 'interrupts' property.
> >>
> >> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> >> ---
> >>  Documentation/devicetree/bindings/input/lpc32xx-key.txt | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> > 
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > 
> 
> can you please pull this documentation change through Linux input branch?
> 
> The two other dts changes have been already included into arm-soc.

Applied, thank you.

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/input/lpc32xx-key.txt b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
index bcf62f856358..2b075a080d30 100644
--- a/Documentation/devicetree/bindings/input/lpc32xx-key.txt
+++ b/Documentation/devicetree/bindings/input/lpc32xx-key.txt
@@ -8,6 +8,7 @@  Required Properties:
 - reg: Physical base address of the controller and length of memory mapped
   region.
 - interrupts: The interrupt number to the cpu.
+- clocks: phandle to clock controller plus clock-specifier pair
 - nxp,debounce-delay-ms: Debounce delay in ms
 - nxp,scan-delay-ms: Repeated scan period in ms
 - linux,keymap: the key-code to be reported when the key is pressed
@@ -22,7 +23,9 @@  Example:
 	key@40050000 {
 		compatible = "nxp,lpc3220-key";
 		reg = <0x40050000 0x1000>;
-		interrupts = <54 0>;
+		clocks = <&clk LPC32XX_CLK_KEY>;
+		interrupt-parent = <&sic1>;
+		interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
 		keypad,num-rows = <1>;
 		keypad,num-columns = <1>;
 		nxp,debounce-delay-ms = <3>;