arm64: dts: rock960: Enable HDMI audio devices
diff mbox series

Message ID 20190129113324.29440-1-ezequiel@collabora.com
State New
Headers show
Series
  • arm64: dts: rock960: Enable HDMI audio devices
Related show

Commit Message

Ezequiel Garcia Jan. 29, 2019, 11:33 a.m. UTC
This commit enable the hdmi-sound and i2s2 devices needed
to have audio over HDMI.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Manivannan Sadhasivam Jan. 29, 2019, 11:40 a.m. UTC | #1
On Tue, Jan 29, 2019 at 08:33:24AM -0300, Ezequiel Garcia wrote:
> This commit enable the hdmi-sound and i2s2 devices needed
> to have audio over HDMI.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>

Since this patch affects both Rock960 and Ficus, it should be mentioned
in the description. Other than that,

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> index f04a31d48ba4..1bbf0b1f9374 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> @@ -94,6 +94,10 @@
>  	status = "okay";
>  };
>  
> +&hdmi_sound {
> +	status = "okay";
> +};
> +
>  &i2c0 {
>  	clock-frequency = <400000>;
>  	i2c-scl-rising-time-ns = <168>;
> @@ -336,6 +340,10 @@
>  	status = "okay";
>  };
>  
> +&i2s2 {
> +        status = "okay";
> +};
> +
>  &io_domains {
>  	bt656-supply = <&vcc1v8_s0>; /* bt656_gpio2ab_ms */
>  	audio-supply = <&vcc1v8_s0>; /* audio_gpio3d4a_ms */
> -- 
> 2.20.1
>
Ezequiel Garcia Jan. 29, 2019, 12:08 p.m. UTC | #2
On Tue, 2019-01-29 at 17:10 +0530, Manivannan Sadhasivam wrote:
> On Tue, Jan 29, 2019 at 08:33:24AM -0300, Ezequiel Garcia wrote:
> > This commit enable the hdmi-sound and i2s2 devices needed
> > to have audio over HDMI.
> > 
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> 
> Since this patch affects both Rock960 and Ficus, it should be mentioned
> in the description. Other than that,
> 

Wish with named this Ficus board as just Rock960 EE, so it'd be obvious
that it's part of the Rock960 family.

> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 

Thanks!

> Thanks,
> Mani
> 
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > index f04a31d48ba4..1bbf0b1f9374 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > @@ -94,6 +94,10 @@
> >  	status = "okay";
> >  };
> >  
> > +&hdmi_sound {
> > +	status = "okay";
> > +};
> > +
> >  &i2c0 {
> >  	clock-frequency = <400000>;
> >  	i2c-scl-rising-time-ns = <168>;
> > @@ -336,6 +340,10 @@
> >  	status = "okay";
> >  };
> >  
> > +&i2s2 {
> > +        status = "okay";
> > +};
> > +
> >  &io_domains {
> >  	bt656-supply = <&vcc1v8_s0>; /* bt656_gpio2ab_ms */
> >  	audio-supply = <&vcc1v8_s0>; /* audio_gpio3d4a_ms */
> > -- 
> > 2.20.1
> >
Heiko Stuebner Feb. 3, 2019, 8:49 a.m. UTC | #3
Am Dienstag, 29. Januar 2019, 13:08:11 CET schrieb Ezequiel Garcia:
> On Tue, 2019-01-29 at 17:10 +0530, Manivannan Sadhasivam wrote:
> > On Tue, Jan 29, 2019 at 08:33:24AM -0300, Ezequiel Garcia wrote:
> > > This commit enable the hdmi-sound and i2s2 devices needed
> > > to have audio over HDMI.
> > > 
> > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > 
> > Since this patch affects both Rock960 and Ficus, it should be mentioned
> > in the description. Other than that,

I've adapted the subject a bit (arm64: dts: rockchip: Eanble HDMI audio
devices on rk3399-rock960), mentioned rock960 and ficus in the message
and applied the result for 5.1

Thanks
Heiko

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
index f04a31d48ba4..1bbf0b1f9374 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
@@ -94,6 +94,10 @@ 
 	status = "okay";
 };
 
+&hdmi_sound {
+	status = "okay";
+};
+
 &i2c0 {
 	clock-frequency = <400000>;
 	i2c-scl-rising-time-ns = <168>;
@@ -336,6 +340,10 @@ 
 	status = "okay";
 };
 
+&i2s2 {
+        status = "okay";
+};
+
 &io_domains {
 	bt656-supply = <&vcc1v8_s0>; /* bt656_gpio2ab_ms */
 	audio-supply = <&vcc1v8_s0>; /* audio_gpio3d4a_ms */