From patchwork Tue Jan 29 15:45:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nishad Kamdar X-Patchwork-Id: 10786511 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B3E9891E for ; Tue, 29 Jan 2019 15:45:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9DFEF2CDB8 for ; Tue, 29 Jan 2019 15:45:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 918DD2CEDA; Tue, 29 Jan 2019 15:45:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 48E342CDB8 for ; Tue, 29 Jan 2019 15:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=IKHvTKHBnzgejHFFW0u6Ui7e6rodldnx7VFHWO526Uo=; b=KWDxDHN2x0Zmtd 68ny1Cb8KzMY1jTVGgWzDoDeIye32oXPIZ/iwHfA7p4RKjvYnZlwwzAK5Ph+hRAHljvpfyvcfqlJm f9VaroRC67D+ENSEkV9QQCLKNWE1kDxiNXq0LJENYe/wW6lpaqCzOQMBGplrwH8qJx6Fa7EG1px7j lHqPpObzfPHWfbCk51FbtDXuuC2I/C857e0y8lqZ5skYX301kp4DfmywGv8B7JoQ6ZcTd2oFR7SsX sp/3fdDTiI/f8sRMSXQUZ5CduAmEGTbEikNGIgwxXn2nGVlxJ2yUoj2bErGr9H1HI+24qianKhvHI 7jGVtGK9TnVsUDGL7FEw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goVZu-0000Cc-A6; Tue, 29 Jan 2019 15:45:34 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1goVZg-0008Sp-MJ; Tue, 29 Jan 2019 15:45:22 +0000 Received: by mail-pf1-x443.google.com with SMTP id u6so9813885pfh.11; Tue, 29 Jan 2019 07:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=2hL+n8s3PZPDTVR3C3fsWQ4CUK8XIxnsp6gmvT4RKy4=; b=iky8fOpDKopaxVP5oB+m/gza7nNYX98IttZ9Ou3fFLtC0Q2Rqf8LzajWHG+agWM3Sw wHo/jk63ro7ORYasiFmXLcCClY7rx3lkYnjRSmbB4p3UcvkoqS/+uHB7Vh9S9c3rNC/k ffB5EYudjdgAoZ7O93gXMppWeFky4qU3qs7VxQXFuCug4gQV4C8wagJB2gILgZfSHKiM MdQSHljJhpXiH3KrXtrgTO0PSA8s423H9Qd1YwFJWdgbiVCEyBT1Zx9dd6MyIXZ7C3m4 M9CCOwCfVt4lRLE5jzQVQttbosHGdgb5wZ6VyjWklz0D/LLvBnI8qCO7/YG5lfguLtZ/ RRiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=2hL+n8s3PZPDTVR3C3fsWQ4CUK8XIxnsp6gmvT4RKy4=; b=eiaE7DlSDCaYrzMIYT+yyvUmdFKefKfiq+kNp7X7rKB+VgHaEYmTQ88mKYGd+hORko jciHQ5p0YR4ZpakezGYABZq6uqADfmgESRhqoAFi1mkVElGkHmrN8U+BNYARNti6dLik H+9Y+byWRouwNnSqNsuwgmIDQ1DymYtWmTsMZCm8xGDPg7XiCztMtIhAP1kFP2BdG1Gy SmzZD9yXL2EQVLz4eFYi192/OBrTay2qzfIaO37szv6Otkza/d1MIGaQ9BMXeFy+9C9Y IHln3F9jnuuVyIt5v4A0NAVjPMqMmlEBxexs8lCTjChQyQCAPib+kdRP57KgslMhKXOY oXOA== X-Gm-Message-State: AJcUukf54e/N6kyxJoB8F2FkbpG0RFQRpfd3x4NMBQcWpfE3Liqk8Avb jKNR4RIn/Cmp4UYvTlEqpIQ= X-Google-Smtp-Source: ALg8bN5XE/W25hqzW7cVy6uuZTOVgGIDj/6VzVf76Uweg1cDJ9QLj+yuRPdAFWbEgoVP7RrzDWhiCg== X-Received: by 2002:a63:e247:: with SMTP id y7mr23038857pgj.84.1548776720057; Tue, 29 Jan 2019 07:45:20 -0800 (PST) Received: from nishad ([106.51.25.107]) by smtp.gmail.com with ESMTPSA id w11sm45165929pgk.16.2019.01.29.07.45.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Jan 2019 07:45:19 -0800 (PST) Date: Tue, 29 Jan 2019 21:15:12 +0530 From: Nishad Kamdar To: Greg Kroah-Hartman , Joe Perches Subject: [PATCH] staging: mt7621-pinctrl: Test devm_kzalloc for failure while improving the code Message-ID: <20190129154507.GA25365@nishad> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190129_074520_780570_067CD2FB X-CRM114-Status: GOOD ( 11.30 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Kees Cook , Sergio Paracuellos , linux-kernel@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, NeilBrown , linux-arm-kernel@lists.infradead.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch tests the return of devm_kzalloc for failure and improves the code. Signed-off-by: Nishad Kamdar --- drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c index 3e959fa73703..9b52d44abef1 100644 --- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c +++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c @@ -350,7 +350,6 @@ static int rt2880_pinmux_probe(struct platform_device *pdev) for_each_compatible_node(np, NULL, "ralink,rt2880-gpio") { const __be32 *ngpio, *gpiobase; struct pinctrl_gpio_range *range; - char *name; if (!of_device_is_available(np)) continue; @@ -362,9 +361,10 @@ static int rt2880_pinmux_probe(struct platform_device *pdev) return -EINVAL; } - range = devm_kzalloc(p->dev, sizeof(*range) + 4, GFP_KERNEL); - range->name = name = (char *)&range[1]; - sprintf(name, "pio"); + range = devm_kzalloc(p->dev, sizeof(*range), GFP_KERNEL); + if (!range) + return -ENOMEM; + range->name = "pio"; range->npins = __be32_to_cpu(*ngpio); range->base = __be32_to_cpu(*gpiobase); range->pin_base = range->base;