[for-5.0] ath10k: correct bus type for WCN3990
diff mbox series

Message ID 20190129231201.42230-1-briannorris@chromium.org
State New
Headers show
Series
  • [for-5.0] ath10k: correct bus type for WCN3990
Related show

Commit Message

Brian Norris Jan. 29, 2019, 11:12 p.m. UTC
WCN3990 is SNOC, not PCI. This prevents probing WCN3990.

Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params")
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
This was a regression in 4.20.

 drivers/net/wireless/ath/ath10k/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bjorn Andersson Jan. 30, 2019, 6:10 a.m. UTC | #1
On Tue 29 Jan 15:12 PST 2019, Brian Norris wrote:

> WCN3990 is SNOC, not PCI. This prevents probing WCN3990.
> 
> Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params")
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
> This was a regression in 4.20.
> 
>  drivers/net/wireless/ath/ath10k/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index 399b501f3c3c..e8891f5fc83a 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -548,7 +548,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
>  	{
>  		.id = WCN3990_HW_1_0_DEV_VERSION,
>  		.dev_id = 0,
> -		.bus = ATH10K_BUS_PCI,
> +		.bus = ATH10K_BUS_SNOC,
>  		.name = "wcn3990 hw1.0",
>  		.continuous_frag_desc = true,
>  		.tx_chain_mask = 0x7,
> -- 
> 2.20.1.495.gaa96b0ce6b-goog
>
Kalle Valo Jan. 30, 2019, 10:11 a.m. UTC | #2
Brian Norris <briannorris@chromium.org> writes:

> WCN3990 is SNOC, not PCI. This prevents probing WCN3990.
>
> Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> This was a regression in 4.20.

I'll queue this for 5.0.
Kalle Valo Jan. 31, 2019, 4:57 p.m. UTC | #3
Brian Norris <briannorris@chromium.org> wrote:

> WCN3990 is SNOC, not PCI. This prevents probing WCN3990.
> 
> Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Patch applied to wireless-drivers.git, thanks.

2c2008a63e48 ath10k: correct bus type for WCN3990

Patch
diff mbox series

diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 399b501f3c3c..e8891f5fc83a 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -548,7 +548,7 @@  static const struct ath10k_hw_params ath10k_hw_params_list[] = {
 	{
 		.id = WCN3990_HW_1_0_DEV_VERSION,
 		.dev_id = 0,
-		.bus = ATH10K_BUS_PCI,
+		.bus = ATH10K_BUS_SNOC,
 		.name = "wcn3990 hw1.0",
 		.continuous_frag_desc = true,
 		.tx_chain_mask = 0x7,