LSM: SafeSetID: remove unused include
diff mbox series

Message ID 20190130155643.167055-1-mortonm@chromium.org
State New
Headers show
Series
  • LSM: SafeSetID: remove unused include
Related show

Commit Message

Micah Morton Jan. 30, 2019, 3:56 p.m. UTC
From: Micah Morton <mortonm@chromium.org>

The include for asm/syscall.h was needed in a prior version of lsm.c
that checked return values of syscall_get_nr, but since we did away with
that part of the code this include is no longer necessary. Take out this
include since it breaks builds for certain architectures. We no longer
have any arch-specific code in SafeSetID.

Signed-off-by: Micah Morton <mortonm@chromium.org>
---
 security/safesetid/lsm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

James Morris Jan. 30, 2019, 8:30 p.m. UTC | #1
On Wed, 30 Jan 2019, mortonm@chromium.org wrote:

> From: Micah Morton <mortonm@chromium.org>
> 
> The include for asm/syscall.h was needed in a prior version of lsm.c
> that checked return values of syscall_get_nr, but since we did away with
> that part of the code this include is no longer necessary. Take out this
> include since it breaks builds for certain architectures. We no longer
> have any arch-specific code in SafeSetID.
> 
> Signed-off-by: Micah Morton <mortonm@chromium.org>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general


> ---
>  security/safesetid/lsm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/security/safesetid/lsm.c b/security/safesetid/lsm.c
> index 282a242beb86..cecd38e2ac80 100644
> --- a/security/safesetid/lsm.c
> +++ b/security/safesetid/lsm.c
> @@ -14,7 +14,6 @@
>  
>  #define pr_fmt(fmt) "SafeSetID: " fmt
>  
> -#include <asm/syscall.h>
>  #include <linux/hashtable.h>
>  #include <linux/lsm_hooks.h>
>  #include <linux/module.h>
>

Patch
diff mbox series

diff --git a/security/safesetid/lsm.c b/security/safesetid/lsm.c
index 282a242beb86..cecd38e2ac80 100644
--- a/security/safesetid/lsm.c
+++ b/security/safesetid/lsm.c
@@ -14,7 +14,6 @@ 
 
 #define pr_fmt(fmt) "SafeSetID: " fmt
 
-#include <asm/syscall.h>
 #include <linux/hashtable.h>
 #include <linux/lsm_hooks.h>
 #include <linux/module.h>