[v2] selftests: kmod: worked on errors which breaks the overall execution of the test script. i have manually edited for v2 of the patch by changing the date and also commit log.
diff mbox series

Message ID 20190131183109.10919-1-jeffrin@rajagiritech.edu.in
State New
Headers show
Series
  • [v2] selftests: kmod: worked on errors which breaks the overall execution of the test script. i have manually edited for v2 of the patch by changing the date and also commit log.
Related show

Commit Message

Jeffrin Thalakkottoor Jan. 31, 2019, 6:31 p.m. UTC
The kmod.sh script breaks because an array is passed as input
instead of a single element input.This patch takes elements
one at a time and passed as input to the condition statement
which in turn fixes the error.There was an issue which had
the need for passing a single digit to the condition statement
which is fixed using regular expression.
Distribution: Debian GNU/Linux buster/sid
Bash Version: 5.0.0(1)-release

Signed-off-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in>
---
 tools/testing/selftests/kmod/kmod.sh | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Luis Chamberlain Feb. 11, 2019, 9:40 p.m. UTC | #1
Your subject is too long.

On Fri, Feb 01, 2019 at 12:01:09AM +0530, Jeffrin Jose T wrote:
> The kmod.sh script breaks because an array is passed as input
> instead of a single element input.This patch takes elements
> one at a time and passed as input to the condition statement
> which in turn fixes the error.There was an issue which had
> the need for passing a single digit to the condition statement
> which is fixed using regular expression.
> Distribution: Debian GNU/Linux buster/sid
> Bash Version: 5.0.0(1)-release

I just tried Debian unstabe with bash 5.0-2 and the issue is not
present there. Debian testing was on 4.4.18-3.1 for me prior to
the upgrade.

*both* work fine.

Please upgrade bash?

  Luis
Jeffrin Thalakkottoor Feb. 14, 2019, 6:26 p.m. UTC | #2
> Your subject is too long.
ok . i have changed it


> Please upgrade bash?
anyway now i have an upgraded one.

here  is a clipping related to the error
---------------------x-------------------x----------------
Thu Feb 14 23:49:13 IST 2019
Running test: kmod_test_0007 - run #4
kmod_test_0005: OK! - loading kmod test
kmod_test_0005: OK! - Return value: 0 (SUCCESS), expected SUCCESS
kmod_test_0006: OK! - loading kmod test
kmod_test_0006: OK! - Return value: 0 (SUCCESS), expected SUCCESS
./kmod.sh: line 529: [[: 1 0002:3:1 0003:1:1 0004:1:1 0005:10:1
0006:10:1 0007:5:1 0008:150:1 0009:150:1: syntax error in expression
(error token is "0002:3:1 0003:1:1 0004:1:1 0005:10:1 0006:10:1
0007:5:1 0008:150:1 0009:150:1")
./kmod.sh: line 529: [[: 1 0002:3:1 0003:1:1 0004:1:1 0005:10:1
0006:10:1 0007:5:1 0008:150:1 0009:150:1: syntax error in expression
(error token is "0002:3:1 0003:1:1 0004:1:1 0005:10:1 0006:10:1
0007:5:1 0008:150:1 0009:150:1")
Test completed
$
------------------x---------------------x----------------------
Luis Chamberlain March 14, 2019, 2:20 p.m. UTC | #3
On Thu, Feb 14, 2019 at 11:56:46PM +0530, Jeffrin Thalakkottoor wrote:
> > Your subject is too long.
> ok . i have changed it
> 
> 
> > Please upgrade bash?
> anyway now i have an upgraded one.
> 
> here  is a clipping related to the error
> ---------------------x-------------------x----------------
> Thu Feb 14 23:49:13 IST 2019
> Running test: kmod_test_0007 - run #4
> kmod_test_0005: OK! - loading kmod test
> kmod_test_0005: OK! - Return value: 0 (SUCCESS), expected SUCCESS
> kmod_test_0006: OK! - loading kmod test
> kmod_test_0006: OK! - Return value: 0 (SUCCESS), expected SUCCESS
> ./kmod.sh: line 529: [[: 1 0002:3:1 0003:1:1 0004:1:1 0005:10:1
> 0006:10:1 0007:5:1 0008:150:1 0009:150:1: syntax error in expression
> (error token is "0002:3:1 0003:1:1 0004:1:1 0005:10:1 0006:10:1
> 0007:5:1 0008:150:1 0009:150:1")
> ./kmod.sh: line 529: [[: 1 0002:3:1 0003:1:1 0004:1:1 0005:10:1
> 0006:10:1 0007:5:1 0008:150:1 0009:150:1: syntax error in expression
> (error token is "0002:3:1 0003:1:1 0004:1:1 0005:10:1 0006:10:1
> 0007:5:1 0008:150:1 0009:150:1")
> Test completed
> $

I do not see this at all. Does anyone else see it?

  Luis

Patch
diff mbox series

diff --git a/tools/testing/selftests/kmod/kmod.sh b/tools/testing/selftests/kmod/kmod.sh
index 0a76314b4414..49b273c3646e 100755
--- a/tools/testing/selftests/kmod/kmod.sh
+++ b/tools/testing/selftests/kmod/kmod.sh
@@ -526,9 +526,12 @@  function run_all_tests()
 		TEST_ID=${i%:*:*}
 		ENABLED=$(get_test_enabled $TEST_ID)
 		TEST_COUNT=$(get_test_count $TEST_ID)
-		if [[ $ENABLED -eq "1" ]]; then
-			test_case $TEST_ID $TEST_COUNT
-		fi
+		for j in $ENABLED ; do
+		         CHECK=${j#*:*:}
+			 if [[ $CHECK -eq "1" ]]; then
+			     test_case $TEST_ID $TEST_COUNT
+			 fi
+		done
 	done
 }