[-next] remoteproc: make rproc_check_carveout_da static
diff mbox series

Message ID 20190201031317.18820-1-yuehaibing@huawei.com
State New
Headers show
Series
  • [-next] remoteproc: make rproc_check_carveout_da static
Related show

Commit Message

Yuehaibing Feb. 1, 2019, 3:13 a.m. UTC
Fixes the following sparse warnings:

drivers/remoteproc/remoteproc_core.c:279:5: warning:
 symbol 'rproc_check_carveout_da' was not declared. Should it be static?

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/remoteproc/remoteproc_core.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Loic Pallardy Feb. 1, 2019, 3:56 p.m. UTC | #1
Hi Yue,

> -----Original Message-----
> From: linux-remoteproc-owner@vger.kernel.org <linux-remoteproc-
> owner@vger.kernel.org> On Behalf Of YueHaibing
> Sent: vendredi 1 février 2019 04:13
> To: ohad@wizery.com; bjorn.andersson@linaro.org
> Cc: linux-kernel@vger.kernel.org; linux-remoteproc@vger.kernel.org;
> YueHaibing <yuehaibing@huawei.com>
> Subject: [PATCH -next] remoteproc: make rproc_check_carveout_da static
> 
> Fixes the following sparse warnings:
> 
> drivers/remoteproc/remoteproc_core.c:279:5: warning:
>  symbol 'rproc_check_carveout_da' was not declared. Should it be static?
Correction already sent on ML few weeks ago. See [1]

Regards,
Loic

[1] https://patchwork.kernel.org/patch/10755763/

> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/remoteproc/remoteproc_core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index 54ec38f..5d4954d 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -276,8 +276,9 @@ rproc_find_carveout_by_name(struct rproc *rproc,
> const char *name, ...)
>   *
>   * Return: 0 if carveout match request else -ENOMEM
>   */
> -int rproc_check_carveout_da(struct rproc *rproc, struct rproc_mem_entry
> *mem,
> -			    u32 da, u32 len)
> +static int rproc_check_carveout_da(struct rproc *rproc,
> +				   struct rproc_mem_entry *mem,
> +				   u32 da, u32 len)
>  {
>  	struct device *dev = &rproc->dev;
>  	int delta = 0;
> --
> 2.7.0
>

Patch
diff mbox series

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 54ec38f..5d4954d 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -276,8 +276,9 @@  rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...)
  *
  * Return: 0 if carveout match request else -ENOMEM
  */
-int rproc_check_carveout_da(struct rproc *rproc, struct rproc_mem_entry *mem,
-			    u32 da, u32 len)
+static int rproc_check_carveout_da(struct rproc *rproc,
+				   struct rproc_mem_entry *mem,
+				   u32 da, u32 len)
 {
 	struct device *dev = &rproc->dev;
 	int delta = 0;