| Message ID | 20190201084801.10983-13-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/18] MIPS: lantiq: pass struct device to DMA API functions | expand |
Christoph Hellwig <hch@lst.de> writes: > dma_map_single already transfers ownership to the device. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Do you want me to take the USB bits or will you take the entire series? In case you're taking the entire series: Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com> > --- > drivers/usb/gadget/udc/fotg210-udc.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c > index bc6abaea907d..fe9cf415f2f1 100644 > --- a/drivers/usb/gadget/udc/fotg210-udc.c > +++ b/drivers/usb/gadget/udc/fotg210-udc.c > @@ -356,10 +356,6 @@ static void fotg210_start_dma(struct fotg210_ep *ep, > return; > } > > - dma_sync_single_for_device(NULL, d, length, > - ep->dir_in ? DMA_TO_DEVICE : > - DMA_FROM_DEVICE); > - > fotg210_enable_dma(ep, d, length); > > /* check if dma is done */ > -- > 2.20.1 >
On Fri, Feb 01, 2019 at 03:19:41PM +0200, Felipe Balbi wrote: > Christoph Hellwig <hch@lst.de> writes: > > > dma_map_single already transfers ownership to the device. > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Do you want me to take the USB bits or will you take the entire series? > In case you're taking the entire series: If you want to take the USB feel free. I just want most of this in this merge window if possible.
On Fri, Feb 01, 2019 at 05:10:26PM +0100, Christoph Hellwig wrote: > On Fri, Feb 01, 2019 at 03:19:41PM +0200, Felipe Balbi wrote: > > Christoph Hellwig <hch@lst.de> writes: > > > > > dma_map_single already transfers ownership to the device. > > > > > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > > > Do you want me to take the USB bits or will you take the entire series? > > In case you're taking the entire series: > > If you want to take the USB feel free. I just want most of this in > this merge window if possible. I didn't see in the USB tree yet, so please let me know if you want to take it.
Hi, Christoph Hellwig <hch@lst.de> writes: > On Fri, Feb 01, 2019 at 05:10:26PM +0100, Christoph Hellwig wrote: >> On Fri, Feb 01, 2019 at 03:19:41PM +0200, Felipe Balbi wrote: >> > Christoph Hellwig <hch@lst.de> writes: >> > >> > > dma_map_single already transfers ownership to the device. >> > > >> > > Signed-off-by: Christoph Hellwig <hch@lst.de> >> > >> > Do you want me to take the USB bits or will you take the entire series? >> > In case you're taking the entire series: >> >> If you want to take the USB feel free. I just want most of this in >> this merge window if possible. > > I didn't see in the USB tree yet, so please let me know if you want to > take it. sorry for the delay, just took it to my tree.
diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c index bc6abaea907d..fe9cf415f2f1 100644 --- a/drivers/usb/gadget/udc/fotg210-udc.c +++ b/drivers/usb/gadget/udc/fotg210-udc.c @@ -356,10 +356,6 @@ static void fotg210_start_dma(struct fotg210_ep *ep, return; } - dma_sync_single_for_device(NULL, d, length, - ep->dir_in ? DMA_TO_DEVICE : - DMA_FROM_DEVICE); - fotg210_enable_dma(ep, d, length); /* check if dma is done */
dma_map_single already transfers ownership to the device. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/usb/gadget/udc/fotg210-udc.c | 4 ---- 1 file changed, 4 deletions(-)