| Message ID | 20190201145519.12228-1-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Set ->connectors_changed to force HDCP updates | expand |
On Fri, Feb 01, 2019 at 03:55:19PM +0100, Daniel Vetter wrote: > ->mode_changed will be eaten by fastset, which is now enabled by > default on at least some platforms. Once we have modeset-less hdcp, we > need to go back to ->mode_changed (or maybe directly setting > ->update_pipe) to avoid the modeset. > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Cc: Ramalingam C <ramalingm.c@intel.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> I think this was broken by the patch to enable fastset everywhere: Fixes: d19f958db23c ("drm/i915: Enable fastset for non-boot modesets.") But we also don't have any hdcp tests in CI, because the shard runs don't have hdcp capable outputs :-/ -Daniel > --- > drivers/gpu/drm/i915/intel_hdcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c > index ce7ba3a9c000..7da25a7bfccb 100644 > --- a/drivers/gpu/drm/i915/intel_hdcp.c > +++ b/drivers/gpu/drm/i915/intel_hdcp.c > @@ -864,7 +864,7 @@ void intel_hdcp_atomic_check(struct drm_connector *connector, > > crtc_state = drm_atomic_get_new_crtc_state(new_state->state, > new_state->crtc); > - crtc_state->mode_changed = true; > + crtc_state->connectors_changed = true; > } > > /* Implements Part 3 of the HDCP authorization procedure */ > -- > 2.20.1 >
diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c index ce7ba3a9c000..7da25a7bfccb 100644 --- a/drivers/gpu/drm/i915/intel_hdcp.c +++ b/drivers/gpu/drm/i915/intel_hdcp.c @@ -864,7 +864,7 @@ void intel_hdcp_atomic_check(struct drm_connector *connector, crtc_state = drm_atomic_get_new_crtc_state(new_state->state, new_state->crtc); - crtc_state->mode_changed = true; + crtc_state->connectors_changed = true; } /* Implements Part 3 of the HDCP authorization procedure */
->mode_changed will be eaten by fastset, which is now enabled by default on at least some platforms. Once we have modeset-less hdcp, we need to go back to ->mode_changed (or maybe directly setting ->update_pipe) to avoid the modeset. Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Ramalingam C <ramalingm.c@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/i915/intel_hdcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)